From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Kho2w-0002Ve-7z
	for qemu-devel@nongnu.org; Mon, 22 Sep 2008 12:13:58 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1Kho2u-0002Ti-0a
	for qemu-devel@nongnu.org; Mon, 22 Sep 2008 12:13:57 -0400
Received: from [199.232.76.173] (port=49180 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Kho2t-0002Te-UB
	for qemu-devel@nongnu.org; Mon, 22 Sep 2008 12:13:55 -0400
Received: from e33.co.us.ibm.com ([32.97.110.151]:53778)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <aliguori@us.ibm.com>) id 1Kho2t-00005h-D0
	for qemu-devel@nongnu.org; Mon, 22 Sep 2008 12:13:55 -0400
Received: from d03relay04.boulder.ibm.com (d03relay04.boulder.ibm.com
	[9.17.195.106])
	by e33.co.us.ibm.com (8.13.8/8.13.8) with ESMTP id m8MFHqhf003498
	for <qemu-devel@nongnu.org>; Mon, 22 Sep 2008 11:17:52 -0400
Received: from d03av04.boulder.ibm.com (d03av04.boulder.ibm.com [9.17.195.170])
	by d03relay04.boulder.ibm.com (8.13.8/8.13.8/NCO v9.1) with ESMTP id
	m8MFHcHB196538
	for <qemu-devel@nongnu.org>; Mon, 22 Sep 2008 09:17:38 -0600
Received: from d03av04.boulder.ibm.com (loopback [127.0.0.1])
	by d03av04.boulder.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id
	m8MFGkmX029164
	for <qemu-devel@nongnu.org>; Mon, 22 Sep 2008 09:17:38 -0600
Message-ID: <48D7B070.2020107@us.ibm.com>
Date: Mon, 22 Sep 2008 09:49:20 -0500
From: Anthony Liguori <aliguori@us.ibm.com>
MIME-Version: 1.0
References: <f43fc5580809200712lc47e2f7q3e6e1a7a431b73b1@mail.gmail.com>
In-Reply-To: <f43fc5580809200712lc47e2f7q3e6e1a7a431b73b1@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: Two signalfd_compat threads created: remove one
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: qemu-devel <qemu-devel@nongnu.org>

Blue Swirl wrote:
> Hi,
>
> Function qemu_aio_init() is called from both vl.c and block.c. This
> means that two threads handling signalfd_compat are created. This
> patch removes the call from vl.c.
>   

Thanks for catching this.  I committed a slightly different patch.  We 
already go through the trouble of maintaining an aio_initialized 
variable so I added a simple check to short-cut the aio_init function if 
we've already been initialized.  Your patch isn't necessary a bad one 
though since it's already called from bdrv_init.  Please commit.

Regards,

Anthony Liguori