From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1KhnNA-00019m-Vp
	for qemu-devel@nongnu.org; Mon, 22 Sep 2008 11:30:49 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1KhnN9-00019Y-ST
	for qemu-devel@nongnu.org; Mon, 22 Sep 2008 11:30:48 -0400
Received: from [199.232.76.173] (port=38361 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1KhnN9-00019V-M9
	for qemu-devel@nongnu.org; Mon, 22 Sep 2008 11:30:47 -0400
Received: from an-out-0708.google.com ([209.85.132.242]:26709)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1KhnN9-0008GI-EP
	for qemu-devel@nongnu.org; Mon, 22 Sep 2008 11:30:47 -0400
Received: by an-out-0708.google.com with SMTP id d18so135079and.130
	for <qemu-devel@nongnu.org>; Mon, 22 Sep 2008 08:30:46 -0700 (PDT)
Message-ID: <48D7B9EB.3080903@codemonkey.ws>
Date: Mon, 22 Sep 2008 10:29:47 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] scsi-generic: correct 6-bytes commands
	transfer length
References: <1222095429.4151.12.camel@frecb07144>
In-Reply-To: <1222095429.4151.12.camel@frecb07144>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Laurent Vivier wrote:
> According to SCSI documentation, for 6 bytes commands (READ(6),
> WRITE(6)), if transfer length is 0 it specifies 256 blocks.
>
> Signed-off-by: Laurent Vivier <Laurent.Vivier@bull.net>
>   

Applied.  Thanks.

Regards,

Anthony Liguori

> ---
>  hw/scsi-generic.c |    3 +++
>  1 file changed, 3 insertions(+)
>
> Index: qemu/hw/scsi-generic.c
> ===================================================================
> --- qemu.orig/hw/scsi-generic.c	2008-09-22 10:47:07.000000000 +0200
> +++ qemu/hw/scsi-generic.c	2008-09-22 14:32:22.000000000 +0200
> @@ -352,6 +352,9 @@ static int scsi_length(uint8_t *cmd, int
>      case 0:
>          *len = cmd[4];
>          *cmdlen = 6;
> +        /* length 0 means 256 blocks */
> +        if (*len == 0)
> +            *len = 256;
>          break;
>      case 1:
>      case 2:
>