From: Anthony Liguori <anthony@codemonkey.ws>
To: Jan Niehusmann <jan@gondor.com>
Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org
Subject: [Qemu-devel] Re: [Patch] Segfault with -vnc option
Date: Mon, 22 Sep 2008 13:08:16 -0500 [thread overview]
Message-ID: <48D7DF10.4030004@codemonkey.ws> (raw)
In-Reply-To: <20080922171558.GA11353@x61s.gondor.com>
Jan Niehusmann wrote:
> Hi!
>
Hi Jan,
Very good catch. My only suggestion would be to move this check into
cirrus_vga.c and vmware_vga.c. Even better would be to introduce a
wrapper around callers of dpy_copy.
Regards,
Anthony Liguori
> Signed-off-by: Jan Niehusmann <jan@gondor.com>
>
> --- qemu/vnc.c.orig 2008-09-22 18:38:08.000000000 +0200
> +++ qemu/vnc.c 2008-09-22 18:39:13.000000000 +0200
> @@ -457,6 +457,9 @@
> int pitch = ds->linesize;
> VncState *vs = ds->opaque;
>
> + /* Skip copy when on text console */
> + if(!is_graphic_console()) return;
> +
> vnc_update_client(vs);
>
> if (dst_y > src_y) {
>
> --
> To unsubscribe from this list: send the line "unsubscribe kvm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2008-09-22 18:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-22 17:16 [Qemu-devel] [Patch] Segfault with -vnc option Jan Niehusmann
2008-09-22 18:08 ` Anthony Liguori [this message]
2008-09-22 21:15 ` [Qemu-devel] " andrzej zaborowski
2008-09-23 15:20 ` [Qemu-devel] [PATCH] Wrapper around dpy_copy to fix segfault " Jan Niehusmann
2008-09-24 2:27 ` [Qemu-devel] " andrzej zaborowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48D7DF10.4030004@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=jan@gondor.com \
--cc=kvm@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).