From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1KhpqY-0005zx-0N
	for qemu-devel@nongnu.org; Mon, 22 Sep 2008 14:09:18 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1KhpqW-0005zI-3R
	for qemu-devel@nongnu.org; Mon, 22 Sep 2008 14:09:17 -0400
Received: from [199.232.76.173] (port=45127 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1KhpqV-0005zF-VT
	for qemu-devel@nongnu.org; Mon, 22 Sep 2008 14:09:16 -0400
Received: from nf-out-0910.google.com ([64.233.182.189]:5920)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1KhpqV-0006Iq-IE
	for qemu-devel@nongnu.org; Mon, 22 Sep 2008 14:09:15 -0400
Received: by nf-out-0910.google.com with SMTP id b2so747450nfb.12
	for <qemu-devel@nongnu.org>; Mon, 22 Sep 2008 11:09:14 -0700 (PDT)
Message-ID: <48D7DF10.4030004@codemonkey.ws>
Date: Mon, 22 Sep 2008 13:08:16 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
References: <20080922171558.GA11353@x61s.gondor.com>
In-Reply-To: <20080922171558.GA11353@x61s.gondor.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [Patch] Segfault with -vnc option
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jan Niehusmann <jan@gondor.com>
Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org

Jan Niehusmann wrote:
> Hi!
>   

Hi Jan,

Very good catch.  My only suggestion would be to move this check into 
cirrus_vga.c and vmware_vga.c.  Even better would be to introduce a 
wrapper around callers of dpy_copy.

Regards,

Anthony Liguori

> Signed-off-by: Jan Niehusmann <jan@gondor.com>
>
> --- qemu/vnc.c.orig	2008-09-22 18:38:08.000000000 +0200
> +++ qemu/vnc.c	2008-09-22 18:39:13.000000000 +0200
> @@ -457,6 +457,9 @@
>      int pitch = ds->linesize;
>      VncState *vs = ds->opaque;
>  
> +    /* Skip copy when on text console */
> +    if(!is_graphic_console()) return;
> +
>      vnc_update_client(vs);
>  
>      if (dst_y > src_y) {
>
> --
> To unsubscribe from this list: send the line "unsubscribe kvm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>