From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Ki9BZ-0002w2-C6 for qemu-devel@nongnu.org; Tue, 23 Sep 2008 10:48:17 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Ki9BY-0002vD-M7 for qemu-devel@nongnu.org; Tue, 23 Sep 2008 10:48:16 -0400 Received: from [199.232.76.173] (port=56809 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Ki9BY-0002v3-8T for qemu-devel@nongnu.org; Tue, 23 Sep 2008 10:48:16 -0400 Received: from e1.ny.us.ibm.com ([32.97.182.141]:53345) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Ki9BX-0002kL-Vw for qemu-devel@nongnu.org; Tue, 23 Sep 2008 10:48:16 -0400 Received: from d01relay02.pok.ibm.com (d01relay02.pok.ibm.com [9.56.227.234]) by e1.ny.us.ibm.com (8.13.8/8.13.8) with ESMTP id m8NEmEw4014737 for ; Tue, 23 Sep 2008 10:48:14 -0400 Received: from d01av02.pok.ibm.com (d01av02.pok.ibm.com [9.56.224.216]) by d01relay02.pok.ibm.com (8.13.8/8.13.8/NCO v9.1) with ESMTP id m8NEmESF171808 for ; Tue, 23 Sep 2008 10:48:14 -0400 Received: from d01av02.pok.ibm.com (loopback [127.0.0.1]) by d01av02.pok.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id m8NEmEeg019256 for ; Tue, 23 Sep 2008 10:48:14 -0400 Message-ID: <48D90175.1010009@us.ibm.com> Date: Tue, 23 Sep 2008 09:47:17 -0500 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] Re: [PATCH 0/3] Refactor AIO to allow multiple AIO implementations References: <1222125454-21744-1-git-send-email-ryanh@us.ibm.com> <48D86361.4000405@us.ibm.com> <20080923144319.GM31395@us.ibm.com> In-Reply-To: <20080923144319.GM31395@us.ibm.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Ryan Harper Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org Ryan Harper wrote: > * Anthony Liguori [2008-09-22 22:44]: > >> Can you run the same performance tests with the following patches (using >> sync=on instead of cache=off)? >> >> You'll need my aio_init fix too. I suspect this will give equally good >> performance to your patch set. That's not saying your patch set isn't >> useful, but I would like to get performance to be better for the case >> that we're going through the page cache. >> > > I can run the test, but it is orthogonal to the patchset which is > focused on using O_DIRECT and linux-aio. > Yes, I'm trying to understand where the performance is coming from. The hunch is that supporting multiple simultaneous requests along is what did it. O_SYNC should give similar completion behavior to O_DIRECT. Regards, Anthony Liguori