[Qemu-devel] [PATCH] Add missing dependencies for qemu-doc.*

[Qemu-devel] [PATCH] Add missing dependencies for qemu-doc.*

[Stefan Weil]

[-- Attachment #1: Type: text/plain, Size: 251 bytes --]

This patch fixes some items in Makefile:

* remove duplicate entries from .PHONY
* add missing entries to .PHONY
* sort entries in .PHONY alphabetically

* add missing dependencies for qemu-doc.* targets

Please apply it to svn trunk.

Thanks
Stefan


[-- Attachment #2: Makefile.patch --]
[-- Type: text/x-diff, Size: 991 bytes --]

Remove duplicate entries from .PHONY, add missing entries and sort the rest.
Add missing dependencies for qemu-doc.* targets.

Signed-off-by: Stefan Weil <weil@mail.berlios.de> 

Index: Makefile
===================================================================
--- Makefile	(Revision 5305)
+++ Makefile	(Arbeitskopie)
@@ -2,8 +2,8 @@
 
 include config-host.mak
 
-.PHONY: all clean distclean dvi info install install-doc tar tarbin \
-	speed test html dvi info
+.PHONY: all clean cscope distclean dvi html info install install-doc \
+	recurse-all speed tar tarbin test
 
 VPATH=$(SRC_PATH):$(SRC_PATH)/hw
 
@@ -32,7 +32,7 @@
 LIBS+=-lwinmm -lws2_32 -liphlpapi
 endif
 
-all: $(TOOLS) $(DOCS) recurse-all 
+all: $(TOOLS) $(DOCS) recurse-all
 
 SUBDIR_RULES=$(patsubst %,subdir-%, $(TARGET_DIRS))
 
@@ -288,6 +288,8 @@
 
 html: qemu-doc.html qemu-tech.html
 
+qemu-doc.dvi qemu-doc.html qemu-doc.info: qemu-img.texi qemu-nbd.texi
+
 VERSION ?= $(shell cat VERSION)
 FILE = qemu-$(VERSION)
 

Re: [Qemu-devel] [PATCH] Add missing dependencies for qemu-doc.*

[Anthony Liguori]

Stefan Weil wrote:
> This patch fixes some items in Makefile:
>
> * remove duplicate entries from .PHONY
> * add missing entries to .PHONY
> * sort entries in .PHONY alphabetically
>
> * add missing dependencies for qemu-doc.* targets
>
> Please apply it to svn trunk.
>   

Please include a Signed-off-by.

Regards,

Anthony Liguori

> Thanks
> Stefan
>
>   

Re: [Qemu-devel] [PATCH] Add missing dependencies for qemu-doc.*

[Miklos Vajna]

[-- Attachment #1: Type: text/plain, Size: 283 bytes --]

On Tue, Sep 23, 2008 at 10:35:38PM +0200, Stefan Weil <weil@mail.berlios.de> wrote:
> Signed-off-by: Stefan Weil <weil@mail.berlios.de>

On Tue, Sep 23, 2008 at 03:46:17PM -0500, Anthony Liguori <anthony@codemonkey.ws> wrote:
> Please include a Signed-off-by.

I thought he did? :-)

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

Re: [Qemu-devel] [PATCH] Add missing dependencies for qemu-doc.*

[Anthony Liguori]

Stefan Weil wrote:
> This patch fixes some items in Makefile:
>
> * remove duplicate entries from .PHONY
> * add missing entries to .PHONY
> * sort entries in .PHONY alphabetically
>
> * add missing dependencies for qemu-doc.* targets
>
> Please apply it to svn trunk.
>   

Applied.  Thanks.

Regards,

Anthony Liguori

> Thanks
> Stefan
>
>   

Re: [Qemu-devel] [PATCH] Add missing dependencies for qemu-doc.*

[Anthony Liguori]

Miklos Vajna wrote:
> On Tue, Sep 23, 2008 at 10:35:38PM +0200, Stefan Weil <weil@mail.berlios.de> wrote:
>   
>> Signed-off-by: Stefan Weil <weil@mail.berlios.de>
>>     
>
> On Tue, Sep 23, 2008 at 03:46:17PM -0500, Anthony Liguori <anthony@codemonkey.ws> wrote:
>   
>> Please include a Signed-off-by.
>>     
>
> I thought he did? :-)
>   

Indeed he did.  My mistake.

Regards,

Anthony Liguori