From: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] few compile time warnings removed
Date: Thu, 25 Sep 2008 10:30:57 +0100 [thread overview]
Message-ID: <48DB5A51.6050800@eu.citrix.com> (raw)
In-Reply-To: <48CFCB81.40708@eu.citrix.com>
Could someone take a look at this patch, please?
It should only take few minutes.
Stefano Stabellini wrote:
> Few small changes to remove some compile time warnings:
>
> - we are not initializing the qemu_alarm_timer pointer in
> init_timer_alarm, so I am adding a NULL initialization;
>
> - in the headers include code, we are doing something like:
>
> #ifdef
> /* BSD stuff */
> #else
> #ifndef __sun__
> /* linux stuff */
> #else
> /* sun stuff */
> #endif
> #endif
>
> that works most of the times but it fails when you try to compile qemu
> on mini-os, that is posix but it doesn't define either __sun__ or
> __linux__, so I am changing it to:
>
> #ifdef
> /* BSD stuff */
> #else
> #ifdef __linux__
> /* linux stuff */
> #endif
> #ifdef __sun__
> /* sun stuff */
> #endif
> #endif
>
> Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
>
> diff --git a/vl.c b/vl.c
> index 0d96401..69aee16 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -70,7 +70,7 @@
> #elif defined (__GLIBC__) && defined (__FreeBSD_kernel__)
> #include <freebsd/stdlib.h>
> #else
> -#ifndef __sun__
> +#ifdef __linux__
> #include <linux/if.h>
> #include <linux/if_tun.h>
> #include <pty.h>
> @@ -84,7 +84,8 @@
>
> #include <linux/ppdev.h>
> #include <linux/parport.h>
> -#else
> +#endif
> +#ifdef __sun__
> #include <sys/stat.h>
> #include <sys/ethernet.h>
> #include <sys/sockio.h>
> @@ -1676,7 +1677,7 @@ static void win32_rearm_timer(struct qemu_alarm_timer *t)
>
> static void init_timer_alarm(void)
> {
> - struct qemu_alarm_timer *t;
> + struct qemu_alarm_timer *t = NULL;
> int i, err = -1;
>
> for (i = 0; alarm_timers[i].name; i++) {
>
>
next prev parent reply other threads:[~2008-09-25 9:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-16 15:06 [Qemu-devel] [PATCH] few compile time warnings removed Stefano Stabellini
2008-09-22 9:45 ` Stefano Stabellini
2008-09-25 9:30 ` Stefano Stabellini [this message]
2008-09-25 16:39 ` Blue Swirl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48DB5A51.6050800@eu.citrix.com \
--to=stefano.stabellini@eu.citrix.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).