From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KixKl-0004Uo-NX for qemu-devel@nongnu.org; Thu, 25 Sep 2008 16:21:07 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KixKk-0004UG-8W for qemu-devel@nongnu.org; Thu, 25 Sep 2008 16:21:07 -0400 Received: from [199.232.76.173] (port=51284 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KixKk-0004U6-12 for qemu-devel@nongnu.org; Thu, 25 Sep 2008 16:21:06 -0400 Received: from mail-gx0-f19.google.com ([209.85.217.19]:49585) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KixKj-0004cU-Bp for qemu-devel@nongnu.org; Thu, 25 Sep 2008 16:21:05 -0400 Received: by gxk12 with SMTP id 12so8042854gxk.10 for ; Thu, 25 Sep 2008 13:21:04 -0700 (PDT) Message-ID: <48DBF274.5000005@codemonkey.ws> Date: Thu, 25 Sep 2008 15:20:04 -0500 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] [5274] Add signed versions of save/load functions References: <48DBEDBC.80400@codemonkey.ws> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Blue Swirl Cc: qemu-devel@nongnu.org Blue Swirl wrote: > Right. I think the patch should be split into three operations: signed > version addition, int to size_t change and this dangerous type size > change. Only the first one is obviously correct, which I thought all > of these changes were. > > Thanks for debugging, I'll revert this patch and make new patches for review. > Thanks! Regards, Anthony Liguori