From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Kixe1-000634-Ll
	for qemu-devel@nongnu.org; Thu, 25 Sep 2008 16:41:01 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1Kixe0-00060a-2Y
	for qemu-devel@nongnu.org; Thu, 25 Sep 2008 16:41:01 -0400
Received: from [199.232.76.173] (port=42590 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Kixdz-00060N-UL
	for qemu-devel@nongnu.org; Thu, 25 Sep 2008 16:40:59 -0400
Received: from rn-out-0910.google.com ([64.233.170.191]:24077)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1Kixdz-0007vd-I1
	for qemu-devel@nongnu.org; Thu, 25 Sep 2008 16:40:59 -0400
Received: by rn-out-0910.google.com with SMTP id m61so407031rnd.8
	for <qemu-devel@nongnu.org>; Thu, 25 Sep 2008 13:40:58 -0700 (PDT)
Message-ID: <48DBF71E.1000405@codemonkey.ws>
Date: Thu, 25 Sep 2008 15:39:58 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] preprocessor issue in
	qemu/patch-block-raw-posix.c
References: <20080921204025.GA81055@saturn.kn-bremen.de>	<200809242210.m8OMAcSZ021572@saturn.kn-bremen.de>
	<20080925201703.GA12142@saturn.kn-bremen.de>
In-Reply-To: <20080925201703.GA12142@saturn.kn-bremen.de>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Juergen Lock <nox@jelal.kn-bremen.de>, qemu-devel@nongnu.org, freebsd-emulation@freebsd.org

Juergen Lock wrote:
> I forgot to note that this also needed the following patch:
>   

Why?  This #ifdef is working around a very specific bug.

Regards,

Anthony Liguori

> Index: qemu/block-raw-posix.c
> @@ -545,7 +545,8 @@
>  
>      qemu_aio_set_fd_handler(s->fd, posix_aio_read, NULL, posix_aio_flush, s);
>  
> -#if defined(__linux__) && defined(__GLIBC_PREREQ) && !__GLIBC_PREREQ(2, 4)
> +#if defined(__linux__) && defined(__GLIBC_PREREQ)
> +#if !__GLIBC_PREREQ(2, 4)
>      {
>          /* XXX: aio thread exit seems to hang on RedHat 9 and this init
>             seems to fix the problem. */
> @@ -557,6 +558,7 @@
>          aio_init(&ai);
>      }
>  #endif
> +#endif
>      posix_aio_state = s;
>  
>      return 0;
>
> Signed-off-by: Juergen Lock <nox@jelal.kn-bremen.de>
>
>
>