From: Anthony Liguori <anthony@codemonkey.ws>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] Re: [PATCH] Add USB sys file-system support (v6)
Date: Fri, 26 Sep 2008 09:37:58 -0500 [thread overview]
Message-ID: <48DCF3C6.4020702@codemonkey.ws> (raw)
In-Reply-To: <48DCF317.7AF2A3BC@bttr-software.de>
Robert Riebisch wrote:
> Anthony Liguori wrote:
>
>
>> Thanks for trying to help, but it's *still* whitespace damaged. This
>> may seem like a minor nit but not taking the time to try and make code
>> match up with the rest of the source tree doesn't suggest that much time
>> has been taking to make the code fit in architecturally or to think
>> about any sort of wider interactions. I also like to give an author the
>> chance to fix something because it helps encourage people to do the
>> right thing the first time around.
>>
>
> Isn't there an official GNU indent guide for the QEMU sources?
>
Perhaps, but I use the following in emacs:
(c-add-style "qemu"
'("stroustrup"
(indent-tabs-mode . nil)
(c-basic-offset . 4)
(tab-width . 8)
)
nil)
Perhaps someone can post the appropriate vim-fu too.
Regards,
Anthony Liguori
> Robert Riebisch
>
next prev parent reply other threads:[~2008-09-26 14:39 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-04 23:35 [Qemu-devel] [PATCH] Add USB sys file-system support TJ
2008-09-05 2:06 ` [Qemu-devel] [PATCH] Add USB sys file-system support (v2) TJ
2008-09-05 13:30 ` Jason Wessel
2008-09-05 18:51 ` TJ
2008-09-05 19:19 ` Jason Wessel
2008-09-05 20:28 ` TJ
2008-09-05 20:54 ` Jason Wessel
2008-09-05 21:13 ` [Qemu-devel] [PATCH] Add USB sys file-system support (v3) TJ
2008-09-08 14:47 ` [Qemu-devel] " Jason Wessel
2008-09-17 19:31 ` [Qemu-devel] [PATCH] Add USB sys file-system support (v4) TJ
2008-09-17 20:31 ` [Qemu-devel] " Anthony Liguori
2008-09-17 22:47 ` [Qemu-devel] [PATCH] Add USB sys file-system support (v5) TJ
2008-09-22 19:47 ` Rick Vernam
2008-09-22 22:38 ` Anthony Liguori
2008-09-25 17:34 ` Rick Vernam
2008-09-25 17:45 ` Anthony Liguori
2008-09-22 22:37 ` [Qemu-devel] " Anthony Liguori
2008-09-23 1:23 ` TJ
2008-09-23 1:33 ` [Qemu-devel] [PATCH] Add USB sys file-system support (v6) TJ
2008-09-25 17:45 ` [Qemu-devel] " Anthony Liguori
2008-09-26 13:57 ` Jason Wessel
2008-09-26 14:27 ` Anthony Liguori
2008-09-26 14:35 ` Robert Riebisch
2008-09-26 14:37 ` Anthony Liguori [this message]
2008-09-26 15:13 ` Jason Wessel
2008-09-26 15:37 ` Anthony Liguori
2008-09-30 20:53 ` TJ
2008-10-01 21:21 ` [Qemu-devel] [PATCH] Add USB sys file-system support (v7) TJ
2008-10-01 23:19 ` [Qemu-devel] [PATCH] Add USB sys file-system support (v8) TJ
2008-10-06 16:03 ` Rick Vernam
2008-10-07 8:46 ` TJ
2008-10-07 20:09 ` [Qemu-devel] " Anthony Liguori
2008-09-05 19:20 ` [Qemu-devel] [PATCH] Add USB sys file-system support (v2) TJ
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48DCF3C6.4020702@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).