From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KjETH-0003Gg-JJ for qemu-devel@nongnu.org; Fri, 26 Sep 2008 10:39:03 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KjETG-0003GA-3W for qemu-devel@nongnu.org; Fri, 26 Sep 2008 10:39:03 -0400 Received: from [199.232.76.173] (port=52588 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KjETF-0003G7-SN for qemu-devel@nongnu.org; Fri, 26 Sep 2008 10:39:01 -0400 Received: from wr-out-0506.google.com ([64.233.184.231]:64658) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KjETF-000623-Db for qemu-devel@nongnu.org; Fri, 26 Sep 2008 10:39:01 -0400 Received: by wr-out-0506.google.com with SMTP id c46so550137wra.18 for ; Fri, 26 Sep 2008 07:39:00 -0700 (PDT) Message-ID: <48DCF3C6.4020702@codemonkey.ws> Date: Fri, 26 Sep 2008 09:37:58 -0500 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] Re: [PATCH] Add USB sys file-system support (v6) References: <1220571341.2638.6.camel@hephaestion> <1220580385.2638.15.camel@hephaestion> <48C1346F.3000405@windriver.com> <1220640699.5470.15.camel@hephaestion> <48C1862C.3050307@windriver.com> <1220649226.9611.13.camel@hephaestion> <48C53B04.9030006@windriver.com> <1221679892.17792.6.camel@hephaestion> <48D16904.30104@codemonkey.ws> <1221691647.17792.55.camel@hephaestion> <48D81E26.9080802@codemonkey.ws> <1222133639.18297.13.camel@hephaestion> <48DBCE35.4030607@codemonkey.ws> <48DCEA3E.7010006@windriver.com> <48DCF168.5080502@codemonkey.ws> <48DCF317.7AF2A3BC@bttr-software.de> In-Reply-To: <48DCF317.7AF2A3BC@bttr-software.de> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Robert Riebisch wrote: > Anthony Liguori wrote: > > >> Thanks for trying to help, but it's *still* whitespace damaged. This >> may seem like a minor nit but not taking the time to try and make code >> match up with the rest of the source tree doesn't suggest that much time >> has been taking to make the code fit in architecturally or to think >> about any sort of wider interactions. I also like to give an author the >> chance to fix something because it helps encourage people to do the >> right thing the first time around. >> > > Isn't there an official GNU indent guide for the QEMU sources? > Perhaps, but I use the following in emacs: (c-add-style "qemu" '("stroustrup" (indent-tabs-mode . nil) (c-basic-offset . 4) (tab-width . 8) ) nil) Perhaps someone can post the appropriate vim-fu too. Regards, Anthony Liguori > Robert Riebisch >