From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1KjEjO-0004eP-Qh
	for qemu-devel@nongnu.org; Fri, 26 Sep 2008 10:55:42 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1KjEjM-0004dg-J4
	for qemu-devel@nongnu.org; Fri, 26 Sep 2008 10:55:41 -0400
Received: from [199.232.76.173] (port=56113 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1KjEjM-0004db-7v
	for qemu-devel@nongnu.org; Fri, 26 Sep 2008 10:55:40 -0400
Received: from el-out-1112.google.com ([209.85.162.182]:42165)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1KjEjL-0006jh-NH
	for qemu-devel@nongnu.org; Fri, 26 Sep 2008 10:55:39 -0400
Received: by el-out-1112.google.com with SMTP id s27so228835ele.19
	for <qemu-devel@nongnu.org>; Fri, 26 Sep 2008 07:55:39 -0700 (PDT)
Message-ID: <48DCF7AD.5040301@codemonkey.ws>
Date: Fri, 26 Sep 2008 09:54:37 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] Makefile question
References: <48DBF7A9.1E3EB46@bttr-software.de>	<48DBF8F4.3060701@codemonkey.ws>	<48DBFA61.5296ADA8@bttr-software.de>
	<BAY110-DAV7DCCB8DD408B1FC661D3CB9470@phx.gbl>
In-Reply-To: <BAY110-DAV7DCCB8DD408B1FC661D3CB9470@phx.gbl>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: Robert Riebisch <rr@bttr-software.de>, computers57@hotmail.com

C.W. Betts wrote:
> I have made
> On Sep 25, 2008, at 2:53 PM, Robert Riebisch wrote:
>
>> Anthony Liguori wrote:
>>
>>> Where does the object file come from?
>>
>> Generated from .rc by `windres'.
> I have made a patch that uses windres to identify the version number 
> of the app.  The patch is in the attachments.  Perhaps you can get 
> some pointers from it.
>
> Index: Makefile.target
> ===================================================================
> --- Makefile.target    (revision 5321)
> +++ Makefile.target    (working copy)
> @@ -661,6 +665,7 @@
>  
>  ifdef CONFIG_WIN32
>  SDL_LIBS := $(filter-out -mwindows, $(SDL_LIBS)) -mconsole
> +OBJS+=version.o
>  endif
>  
>  # profiling code
> @@ -676,6 +681,9 @@
>  
>  %.o: %.c
>      $(CC) $(CPPFLAGS) $(CFLAGS) -c -o $@ $<
> +   
> +%.o: %.rc
> +    windres -I. -DORIGINAL_FILENAME=\"$(QEMU_PROG)\" -c -o $< $@

This needs to be ${cross_prefix}windres

>  %.o: %.S
>      $(CC) $(CPPFLAGS) -c -o $@ $<
> Index: configure
> ===================================================================
> --- configure    (revision 5321)
> +++ configure    (working copy)
> @@ -1319,6 +1319,10 @@
>  echo "# Automatically generated by configure - do not modify" > 
> $config_mak
>  echo "/* Automatically generated by configure - do not modify */" > 
> $config_h
>  
> +if test "$mingw32" = "yes" ; then
> +echo "#define QEMU_FILEVERSION $(tr . , < $source_path/VERSION),0" >> 
> $config_h
> +echo "#define QEMU_PRODUCTVERSION $(tr . , < $source_path/VERSION),0" 
> >> $config_h
> +fi
>

You could just use QEMU_VERSION in the .rc file

I think it's a good idea to include a default .rc file for the QEMU 
Windows build.  If you update the patch, I'd be happy to apply it.

Regards,

Anthony Liguori