From: Robert Riebisch <rr@bttr-software.de>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] Makefile question
Date: Fri, 26 Sep 2008 17:30:19 +0200 [thread overview]
Message-ID: <48DD000B.C74F7773@bttr-software.de> (raw)
In-Reply-To: 48DCF7AD.5040301@codemonkey.ws
Anthony Liguori wrote:
> > +
> > +%.o: %.rc
> > + windres -I. -DORIGINAL_FILENAME=\"$(QEMU_PROG)\" -c -o $< $@
>
> This needs to be ${cross_prefix}windres
MinGW's windres doesn't have a "-c" option.
> > +if test "$mingw32" = "yes" ; then
> > +echo "#define QEMU_FILEVERSION $(tr . , < $source_path/VERSION),0" >>
> > $config_h
> > +echo "#define QEMU_PRODUCTVERSION $(tr . , < $source_path/VERSION),0"
> > >> $config_h
> > +fi
> >
>
> You could just use QEMU_VERSION in the .rc file
Instead of QEMU_FILEVERSION and QEMU_PRODUCTVERSION?
No, because FILEVERSION numbers must be in format "a, b, c, d".
> I think it's a good idea to include a default .rc file for the QEMU
> Windows build. If you update the patch, I'd be happy to apply it.
I'll apply it adjusted to my QEMU 0.9.1 sources and see if it's fine.
Robert Riebisch
--
BTTR Software
http://www.bttr-software.de/
next prev parent reply other threads:[~2008-09-26 15:30 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-25 20:42 [Qemu-devel] Makefile question Robert Riebisch
2008-09-25 20:47 ` Anthony Liguori
2008-09-25 20:53 ` Robert Riebisch
[not found] ` <4D85C158-8A93-42F6-B004-D7059D406C12@hotmail.com>
2008-09-26 14:26 ` C.W. Betts
2008-09-26 14:50 ` Robert Riebisch
2008-09-26 14:55 ` Anthony Liguori
2008-09-26 15:06 ` Robert Riebisch
2008-09-26 14:53 ` Robert Riebisch
2008-09-26 14:54 ` Anthony Liguori
2008-09-26 15:30 ` Robert Riebisch [this message]
2008-09-26 15:38 ` Anthony Liguori
2008-09-26 16:00 ` Robert Riebisch
2008-09-26 16:16 ` Anthony Liguori
2008-09-26 16:32 ` Robert Riebisch
2008-09-26 16:52 ` Anthony Liguori
2008-09-26 19:16 ` Robert Riebisch
2008-09-26 16:26 ` Robert Riebisch
2008-09-26 16:23 ` [Qemu-devel] " Consul
2008-09-26 16:45 ` Robert Riebisch
2008-09-26 18:38 ` Anthony Liguori
2008-09-26 16:28 ` [Qemu-devel] " Robert Riebisch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48DD000B.C74F7773@bttr-software.de \
--to=rr@bttr-software.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).