From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1KjFH1-0006uj-2k
	for qemu-devel@nongnu.org; Fri, 26 Sep 2008 11:30:27 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1KjFH0-0006tW-E7
	for qemu-devel@nongnu.org; Fri, 26 Sep 2008 11:30:26 -0400
Received: from [199.232.76.173] (port=47107 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1KjFH0-0006t9-7P
	for qemu-devel@nongnu.org; Fri, 26 Sep 2008 11:30:26 -0400
Received: from mailout.artfiles.de ([80.252.97.80]:54018)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <rr@bttr-software.de>) id 1KjFGz-0000Sj-TJ
	for qemu-devel@nongnu.org; Fri, 26 Sep 2008 11:30:26 -0400
Received: from [87.185.160.209] (helo=bttr-software.de)
	auth=rr@bttr-software.de
	by mailout.artfiles.de with esmtpa (Exim 4.69) id 1KjFGw-00059I-Og
	for qemu-devel@nongnu.org; Fri, 26 Sep 2008 17:30:22 +0200
Message-ID: <48DD000B.C74F7773@bttr-software.de>
Date: Fri, 26 Sep 2008 17:30:19 +0200
From: Robert Riebisch <rr@bttr-software.de>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] Makefile question
References: <48DBF7A9.1E3EB46@bttr-software.de>	<48DBF8F4.3060701@codemonkey.ws>	<48DBFA61.5296ADA8@bttr-software.de>
	<BAY110-DAV7DCCB8DD408B1FC661D3CB9470@phx.gbl>
	<48DCF7AD.5040301@codemonkey.ws>
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Anthony Liguori wrote:

> > +
> > +%.o: %.rc
> > +    windres -I. -DORIGINAL_FILENAME=\"$(QEMU_PROG)\" -c -o $< $@
> 
> This needs to be ${cross_prefix}windres

MinGW's windres doesn't have a "-c" option.

> > +if test "$mingw32" = "yes" ; then
> > +echo "#define QEMU_FILEVERSION $(tr . , < $source_path/VERSION),0" >>
> > $config_h
> > +echo "#define QEMU_PRODUCTVERSION $(tr . , < $source_path/VERSION),0"
> > >> $config_h
> > +fi
> >
> 
> You could just use QEMU_VERSION in the .rc file

Instead of QEMU_FILEVERSION and QEMU_PRODUCTVERSION?
No, because FILEVERSION numbers must be in format "a, b, c, d".

> I think it's a good idea to include a default .rc file for the QEMU
> Windows build.  If you update the patch, I'd be happy to apply it.

I'll apply it adjusted to my QEMU 0.9.1 sources and see if it's fine.

Robert Riebisch
-- 
BTTR Software
http://www.bttr-software.de/