From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Kkgde-0008HH-DJ
	for qemu-devel@nongnu.org; Tue, 30 Sep 2008 10:55:46 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1Kkgdc-0008G7-GC
	for qemu-devel@nongnu.org; Tue, 30 Sep 2008 10:55:45 -0400
Received: from [199.232.76.173] (port=58501 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Kkgdc-0008Fw-19
	for qemu-devel@nongnu.org; Tue, 30 Sep 2008 10:55:44 -0400
Received: from mail-gx0-f19.google.com ([209.85.217.19]:62094)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1Kkgdb-0001O0-Hn
	for qemu-devel@nongnu.org; Tue, 30 Sep 2008 10:55:43 -0400
Received: by gxk12 with SMTP id 12so12800704gxk.10
	for <qemu-devel@nongnu.org>; Tue, 30 Sep 2008 07:55:42 -0700 (PDT)
Message-ID: <48E23DAF.8070509@codemonkey.ws>
Date: Tue, 30 Sep 2008 09:54:39 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] PATCH: fix usb-linux.c compile orror
References: <48DFD2D9.6060205@earthlink.net>
	<48E0FEB4.8000208@codemonkey.ws>	<48E178BE.70508@earthlink.net>
	<48E1830D.1000903@codemonkey.ws>
	<20080930100908.N47083@stanley.csl.cornell.edu>
In-Reply-To: <20080930100908.N47083@stanley.csl.cornell.edu>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Vince Weaver wrote:
>
> On Mon, 29 Sep 2008, Anthony Liguori wrote:
>> Robert Reif wrote:
>>> RH9 system (2.4.20-31.9smp).
>>
>> Huh.  I'm amazed it compiles with just that change on such an old 
>> kernel.
>
> I have similar problems compiling on a SuSE 10.1 system which really 
> isn't that old.  Since I only use linux-user I'd been too lazy to 
> investigate the problem.
>
> Why should Qemu not build on older systems?  I'd imagine that linux 
> 2.4 / 2.6 compatability would be easier to handle than linux /OSX 
> /Windows compatability.

I think we should support 2.4 kernels FWIW.  I'm just waiting for 
someone to send a patch that adds a configure check instead of breaking 
the build for newer kernels.

I think the best way to do it would be to try and detect the right 
header files for usb pass through in configure, and disable usb-linux.c 
entirely if they aren't available.

Regards,

Anthony LIguori

> Vince
>
>