Re: [Qemu-devel] Add Core Duo support

[Alexander Graf <agraf@suse.de>]

Hi,

C.W.Betts wrote:
> This patch adds the Core Duo support from Alexander Graf's patches to 
> add Intel Mac emulation to qemu.

Hey, cool. I'm really glad to hear that they are still in use. But 
please always CC me when you reuse code from me, so I can track on 
what's happening with it :-).
Also it's always nice to mark patches with a "[PATCH]" prefix in the 
subject.

> When looking at the code, I noticed that there wasn't a definition of 
> the Core Duo processor that Alexander's patches requires. There was a 
> Core 2 Duo in the X86_64 definition, but not one available in 32-bit mode.

Yes, I actually wanted to shift everything to the 64-bit version, as 
only a few Macs did not have x86_64 support. I have to admit, that 
there's no real need to do that, so it's probably best to include the 
coreduo and core2duo defines.

> Please note that this patch is more or less a direct copy and doesn't 
> have the Model ID specified.

Hum, I would rather like to see the "real deal" be added, including some 
information on what is missing, just like the core2duo define is too. I 
already extracted the CPUID information from a CoreDuo Macbook Pro and 
will write up and submit a patch soon.

> Also, this patch contains a patch so that the Athlon processor uses 
> the CPUID_VENDOR_AMD_[3] defines.

Please commit this second chunk. I apparently oversaw that one.


Alex