From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Kmq6h-0002QO-Kc for qemu-devel@nongnu.org; Mon, 06 Oct 2008 09:26:39 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Kmq6g-0002Q9-2r for qemu-devel@nongnu.org; Mon, 06 Oct 2008 09:26:39 -0400 Received: from [199.232.76.173] (port=49591 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Kmq6f-0002Q6-Tc for qemu-devel@nongnu.org; Mon, 06 Oct 2008 09:26:37 -0400 Received: from ns.suse.de ([195.135.220.2]:44189 helo=mx1.suse.de) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Kmq6f-0008C6-DX for qemu-devel@nongnu.org; Mon, 06 Oct 2008 09:26:37 -0400 Message-ID: <48EA1208.3000203@suse.de> Date: Mon, 06 Oct 2008 15:26:32 +0200 From: Alexander Graf MIME-Version: 1.0 Subject: Re: [Qemu-devel] Add Core Duo support References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: computers57@hotmail.com Hi, C.W.Betts wrote: > This patch adds the Core Duo support from Alexander Graf's patches to > add Intel Mac emulation to qemu. Hey, cool. I'm really glad to hear that they are still in use. But please always CC me when you reuse code from me, so I can track on what's happening with it :-). Also it's always nice to mark patches with a "[PATCH]" prefix in the subject. > When looking at the code, I noticed that there wasn't a definition of > the Core Duo processor that Alexander's patches requires. There was a > Core 2 Duo in the X86_64 definition, but not one available in 32-bit mode. Yes, I actually wanted to shift everything to the 64-bit version, as only a few Macs did not have x86_64 support. I have to admit, that there's no real need to do that, so it's probably best to include the coreduo and core2duo defines. > Please note that this patch is more or less a direct copy and doesn't > have the Model ID specified. Hum, I would rather like to see the "real deal" be added, including some information on what is missing, just like the core2duo define is too. I already extracted the CPUID information from a CoreDuo Macbook Pro and will write up and submit a patch soon. > Also, this patch contains a patch so that the Athlon processor uses > the CPUID_VENDOR_AMD_[3] defines. Please commit this second chunk. I apparently oversaw that one. Alex