[Qemu-devel] [5440] Add sparse checker support to the build system (Gerd Hoffman)

[Qemu-devel] [5440] Add sparse checker support to the build system (Gerd Hoffman)

[Anthony Liguori]

Revision: 5440
          http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=5440
Author:   aliguori
Date:     2008-10-07 19:16:17 +0000 (Tue, 07 Oct 2008)

Log Message:
-----------
Add sparse checker support to the build system (Gerd Hoffman)

This adds support for running the sparse checker during the build
process.  Left it off by default for now, build becomes very noisy with
sparse checking turned on as it has to complain alot (partly even in the
system headers!).  The qemu code base needs quite some cleanups before
we should consider turning it on by default.

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>

Modified Paths:
--------------
    trunk/configure

Modified: trunk/configure
===================================================================
--- trunk/configure	2008-10-07 19:12:13 UTC (rev 5439)
+++ trunk/configure	2008-10-07 19:16:17 UTC (rev 5440)
@@ -85,6 +85,7 @@
   ;;
 esac
 gprof="no"
+sparse="no"
 bigendian="no"
 mingw32="no"
 EXESUF=""
@@ -285,6 +286,10 @@
   ;;
   --audio-drv-list=*) audio_drv_list="$optarg"
   ;;
+  --enable-sparse) sparse="yes"
+  ;;
+  --disable-sparse) sparse="no"
+  ;;
   --disable-vnc-tls) vnc_tls="no"
   ;;
   --disable-slirp) slirp="no"
@@ -422,6 +427,7 @@
 echo "  --make=MAKE              use specified make [$make]"
 echo "  --install=INSTALL        use specified install [$install]"
 echo "  --static                 enable static build [$static]"
+echo "  --disable-sparse         disable sparse checker"
 echo "  --disable-werror         disable compilation abort on warning"
 echo "  --disable-sdl            disable SDL"
 echo "  --enable-cocoa           enable COCOA (Mac OS X only)"
@@ -532,6 +538,10 @@
     fi
 fi
 
+if test ! -x "$(which cgcc 2>/dev/null)"; then
+    sparse="no"
+fi
+
 #
 # Solaris specific configure tool chain decisions
 #
@@ -987,6 +997,7 @@
 echo "host big endian   $bigendian"
 echo "target list       $target_list"
 echo "gprof enabled     $gprof"
+echo "sparse enabled    $sparse"
 echo "profiler          $profiler"
 echo "static build      $static"
 echo "-Werror enabled   $werror"
@@ -1135,6 +1146,11 @@
     exit 1
   ;;
 esac
+if test "$sparse" = "yes" ; then
+  echo "CC      := REAL_CC=\"\$(CC)\" cgcc"       >> $config_mak
+  echo "HOST_CC := REAL_CC=\"\$(HOST_CC)\" cgcc"  >> $config_mak
+  echo "CFLAGS  += -Wbitwise -Wno-transparent-union -Wno-old-initializer -Wno-non-pointer-null" >> $config_mak
+fi
 if test "$bigendian" = "yes" ; then
   echo "WORDS_BIGENDIAN=yes" >> $config_mak
   echo "#define WORDS_BIGENDIAN 1" >> $config_h

Re: [Qemu-devel] [5440] Add sparse checker support to the build system (Gerd Hoffman)

[Paul Brook]

On Tuesday 07 October 2008, Anthony Liguori wrote:
> +echo "  --disable-sparse         disable sparse checker"

Given this is disabled by default, shouldn't we be 
documenting --enable-sparse?

Re: [Qemu-devel] [5440] Add sparse checker support to the build system (Gerd Hoffman)

[Anthony Liguori]

Paul Brook wrote:
> On Tuesday 07 October 2008, Anthony Liguori wrote:
>   
>> +echo "  --disable-sparse         disable sparse checker"
>>     
>
> Given this is disabled by default, shouldn't we be 
> documenting --enable-sparse?
>   

Yup, I've already asked for a patch that adds this.

Regards,

Anthony Liguori