From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1KnIly-0008O3-HC
	for qemu-devel@nongnu.org; Tue, 07 Oct 2008 16:03:10 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1KnIlx-0008NG-1S
	for qemu-devel@nongnu.org; Tue, 07 Oct 2008 16:03:10 -0400
Received: from [199.232.76.173] (port=46266 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1KnIlw-0008NC-JO
	for qemu-devel@nongnu.org; Tue, 07 Oct 2008 16:03:08 -0400
Received: from ug-out-1314.google.com ([66.249.92.169]:4763)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1KnIlu-000820-Lt
	for qemu-devel@nongnu.org; Tue, 07 Oct 2008 16:03:07 -0400
Received: by ug-out-1314.google.com with SMTP id j3so335995ugf.36
	for <qemu-devel@nongnu.org>; Tue, 07 Oct 2008 13:03:04 -0700 (PDT)
Message-ID: <48EBC073.2010501@codemonkey.ws>
Date: Tue, 07 Oct 2008 15:02:59 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [patch] Add spare checker support to the build system
References: <48EB2FDF.8030603@redhat.com>
	<f43fc5580810071221l2b9e764cwba71129feace3639@mail.gmail.com>
In-Reply-To: <f43fc5580810071221l2b9e764cwba71129feace3639@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Blue Swirl wrote:
> On 10/7/08, Gerd Hoffmann <kraxel@redhat.com> wrote:
>   
>>   Hi,
>>
>>  This adds support for running the sparse checker during the build
>>  process.  Left it off by default for now, build becomes very noisy with
>>  sparse checking turned on as it has to complain alot (partly even in the
>>  system headers!).  The qemu code base needs quite some cleanups before
>>  we should consider turning it on by default.
>>     
>
> Cool, with sparse, I found and fixed one real bug and found one
> missing 'static' just in target-sparc.
>
> The cgcc test should try compiling a program like the C compiler test.
> Maybe those tests could be merged?
>   

It should if we're enabling it by default.  Since we don't enable it by 
default, presumably the user has a working version of sparse.

Also, to enable it by default, we need to think about how it interacts 
with cross compilers and other versions of GCC other than the default gcc.

Regards,

Anthony Liguori