qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Anthony Liguori <anthony@codemonkey.ws>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] Fix IDE DIAGNOSE for packet devices
Date: Thu, 09 Oct 2008 09:19:54 -0500	[thread overview]
Message-ID: <48EE130A.9060503@codemonkey.ws> (raw)
In-Reply-To: <20081009120324.GA25767@kyllikki.org>

Vincent Sanders wrote:
> The DIAGNOSE command in the qemu IDE implementation has an error when
> use dfor packet devices. 
>
> The status register value is dependant on the drive being a packet
> device or not, this patch corrects the returned status.
>
> From the ATA/PI specification (V6 draft):
>
> "If the device implements the PACKET command feature set, the device
> SHALL clear bits 6,5,4,3,2 and 0 in the Status register to zero."
>
> A selection of physical devices have been checked and do conform to
> the specifications behaviour.
>
> Signed-off-by: Vincent Sanders <vince@simtec.co.uk>
>   

Applied.  Thanks.

Regards,

Anthony Liguori

      reply	other threads:[~2008-10-09 14:20 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-09 12:03 [Qemu-devel] [PATCH] Fix IDE DIAGNOSE for packet devices Vincent Sanders
2008-10-09 14:19 ` Anthony Liguori [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48EE130A.9060503@codemonkey.ws \
    --to=anthony@codemonkey.ws \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).