From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KnwMy-0000KB-1q for qemu-devel@nongnu.org; Thu, 09 Oct 2008 10:20:00 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KnwMw-0000IS-At for qemu-devel@nongnu.org; Thu, 09 Oct 2008 10:19:59 -0400 Received: from [199.232.76.173] (port=40012 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KnwMw-0000IB-58 for qemu-devel@nongnu.org; Thu, 09 Oct 2008 10:19:58 -0400 Received: from mail-gx0-f19.google.com ([209.85.217.19]:39201) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KnwMv-0000sd-R2 for qemu-devel@nongnu.org; Thu, 09 Oct 2008 10:19:57 -0400 Received: by gxk12 with SMTP id 12so10144721gxk.10 for ; Thu, 09 Oct 2008 07:19:57 -0700 (PDT) Message-ID: <48EE130A.9060503@codemonkey.ws> Date: Thu, 09 Oct 2008 09:19:54 -0500 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] Fix IDE DIAGNOSE for packet devices References: <20081009120324.GA25767@kyllikki.org> In-Reply-To: <20081009120324.GA25767@kyllikki.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Vincent Sanders wrote: > The DIAGNOSE command in the qemu IDE implementation has an error when > use dfor packet devices. > > The status register value is dependant on the drive being a packet > device or not, this patch corrects the returned status. > > From the ATA/PI specification (V6 draft): > > "If the device implements the PACKET command feature set, the device > SHALL clear bits 6,5,4,3,2 and 0 in the Status register to zero." > > A selection of physical devices have been checked and do conform to > the specifications behaviour. > > Signed-off-by: Vincent Sanders > Applied. Thanks. Regards, Anthony Liguori