From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Koy5j-0005S0-D0
	for qemu-devel@nongnu.org; Sun, 12 Oct 2008 06:22:27 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1Koy5h-0005Rc-L3
	for qemu-devel@nongnu.org; Sun, 12 Oct 2008 06:22:26 -0400
Received: from [199.232.76.173] (port=59117 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Koy5h-0005RZ-CE
	for qemu-devel@nongnu.org; Sun, 12 Oct 2008 06:22:25 -0400
Received: from fmmailgate01.web.de ([217.72.192.221]:45646)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <jan.kiszka@web.de>) id 1Koy5g-0005B1-Mr
	for qemu-devel@nongnu.org; Sun, 12 Oct 2008 06:22:25 -0400
Received: from smtp08.web.de (fmsmtp08.dlan.cinetic.de [172.20.5.216])
	by fmmailgate01.web.de (Postfix) with ESMTP id 18819F57AC30
	for <qemu-devel@nongnu.org>; Sun, 12 Oct 2008 12:22:17 +0200 (CEST)
Received: from [80.226.12.107] (helo=[192.168.0.187])
	by smtp08.web.de with asmtp (TLSv1:AES256-SHA:256)
	(WEB.DE 4.109 #226) id 1Koy5Y-0005OP-00
	for qemu-devel@nongnu.org; Sun, 12 Oct 2008 12:22:17 +0200
Message-ID: <48F1CFBB.2000509@web.de>
Date: Sun, 12 Oct 2008 12:21:47 +0200
From: Jan Kiszka <jan.kiszka@web.de>
MIME-Version: 1.0
References: <E1KopCv-0001X3-Qp@cvs.savannah.gnu.org>
In-Reply-To: <E1KopCv-0001X3-Qp@cvs.savannah.gnu.org>
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="------------enigAE3A09E0D5260DA2E7CE37F8"
Sender: jan.kiszka@web.de
Subject: [Qemu-devel] Re: [5465] hw/apic.c: use __builtin funtions instead
 of assembly code
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

This is an OpenPGP/MIME signed message (RFC 2440 and 3156)
--------------enigAE3A09E0D5260DA2E7CE37F8
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Aurelien Jarno wrote:
> Revision: 5465
>           http://svn.sv.gnu.org/viewvc/?view=3Drev&root=3Dqemu&revision=
=3D5465
> Author:   aurel32
> Date:     2008-10-12 00:53:17 +0000 (Sun, 12 Oct 2008)
>=20
> Log Message:
> -----------
> hw/apic.c: use __builtin funtions instead of assembly code
>=20
> Suggested by malc.
>=20
> Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
>=20
> Modified Paths:
> --------------
>     trunk/hw/apic.c
>=20
> Modified: trunk/hw/apic.c
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> --- trunk/hw/apic.c	2008-10-12 00:53:08 UTC (rev 5464)
> +++ trunk/hw/apic.c	2008-10-12 00:53:17 UTC (rev 5465)
> @@ -104,15 +104,14 @@
>  static void apic_set_irq(APICState *s, int vector_num, int trigger_mod=
e);
>  static void apic_update_irq(APICState *s);
> =20
> -/* Find first bit starting from msb. Return 0 if value =3D 0 */
> +/* Find first bit starting from msb */
>  static int fls_bit(uint32_t value)
>  {
> +#if defined(__GNUC__)
> +    return 31 - __builtin_clz(value);

That as well as most (if not all) of the __builtin_* changes are gcc3.4+
stuff. Thus gcc3.3 builds are unfortunately broken now.

Jan


--------------enigAE3A09E0D5260DA2E7CE37F8
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.9 (GNU/Linux)
Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org

iEYEARECAAYFAkjxz9EACgkQniDOoMHTA+lqKACdFVQ1cgwozD2MjHVStpMfn7WM
5eAAnRHBAKziNXP3kL6FHAbscL+eRIsa
=5wIq
-----END PGP SIGNATURE-----

--------------enigAE3A09E0D5260DA2E7CE37F8--