From: Avi Kivity <avi@redhat.com>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [5466] Only use __builtin_* with GCC >= 3.4
Date: Sun, 12 Oct 2008 14:33:31 +0200 [thread overview]
Message-ID: <48F1EE9B.6040706@redhat.com> (raw)
In-Reply-To: <E1KozNF-0000r1-S2@cvs.savannah.gnu.org>
Aurelien Jarno wrote:
> Revision: 5466
> http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=5466
> Author: aurel32
> Date: 2008-10-12 11:44:36 +0000 (Sun, 12 Oct 2008)
>
> Log Message:
> -----------
> Only use __builtin_* with GCC >= 3.4
>
> Fix gcc 3.3 builds, broken in revision 5465.
>
>
> static always_inline int clz32(uint32_t val)
> {
> -#if defined(__GNUC__)
> +#if defined(__GNUC__) && ((__GNUC__ > 3) || (__GNUC__ == 3 && __GNUC_MINOR__ >= 4))
>
Couldn't this be wrapped in GCC_BUILTINS_AVAILABLE or GCC_ATLEAST_3_4?
My eyes hurt.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2008-10-12 12:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-12 11:44 [Qemu-devel] [5466] Only use __builtin_* with GCC >= 3.4 Aurelien Jarno
2008-10-12 12:33 ` Avi Kivity [this message]
2008-10-12 14:23 ` Jamie Lokier
2008-10-12 15:02 ` Avi Kivity
2008-10-12 15:33 ` Jamie Lokier
2008-10-12 19:10 ` M. Warner Losh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48F1EE9B.6040706@redhat.com \
--to=avi@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).