From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Kp08f-0001J2-Qs
	for qemu-devel@nongnu.org; Sun, 12 Oct 2008 08:33:37 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1Kp08d-0001Hc-Qb
	for qemu-devel@nongnu.org; Sun, 12 Oct 2008 08:33:37 -0400
Received: from [199.232.76.173] (port=59617 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Kp08d-0001HP-Kx
	for qemu-devel@nongnu.org; Sun, 12 Oct 2008 08:33:35 -0400
Received: from mx2.redhat.com ([66.187.237.31]:46677)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <avi@redhat.com>) id 1Kp08d-0004UC-IG
	for qemu-devel@nongnu.org; Sun, 12 Oct 2008 08:33:35 -0400
Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26])
	by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id m9CCXYoJ002131
	for <qemu-devel@nongnu.org>; Sun, 12 Oct 2008 08:33:34 -0400
Message-ID: <48F1EE9B.6040706@redhat.com>
Date: Sun, 12 Oct 2008 14:33:31 +0200
From: Avi Kivity <avi@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [5466] Only use __builtin_* with GCC >= 3.4
References: <E1KozNF-0000r1-S2@cvs.savannah.gnu.org>
In-Reply-To: <E1KozNF-0000r1-S2@cvs.savannah.gnu.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Aurelien Jarno wrote:
> Revision: 5466
>           http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=5466
> Author:   aurel32
> Date:     2008-10-12 11:44:36 +0000 (Sun, 12 Oct 2008)
>
> Log Message:
> -----------
> Only use __builtin_* with GCC >= 3.4
>
> Fix gcc 3.3 builds, broken in revision 5465.
>
>  
>  static always_inline int clz32(uint32_t val)
>  {
> -#if defined(__GNUC__)
> +#if defined(__GNUC__) && ((__GNUC__ > 3) || (__GNUC__ == 3 && __GNUC_MINOR__ >= 4))
>   

Couldn't this be wrapped in GCC_BUILTINS_AVAILABLE or GCC_ATLEAST_3_4?  
My eyes hurt.


-- 
error compiling committee.c: too many arguments to function