From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1KpmKE-0007IY-P2
	for qemu-devel@nongnu.org; Tue, 14 Oct 2008 12:00:46 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1KpmKC-0007Hz-Vx
	for qemu-devel@nongnu.org; Tue, 14 Oct 2008 12:00:46 -0400
Received: from [199.232.76.173] (port=37161 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1KpmKC-0007Hi-89
	for qemu-devel@nongnu.org; Tue, 14 Oct 2008 12:00:44 -0400
Received: from mx2.redhat.com ([66.187.237.31]:51688)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <avi@redhat.com>) id 1KpmKB-0007jV-PK
	for qemu-devel@nongnu.org; Tue, 14 Oct 2008 12:00:44 -0400
Message-ID: <48F4C224.2010606@redhat.com>
Date: Tue, 14 Oct 2008 18:00:36 +0200
From: Avi Kivity <avi@redhat.com>
MIME-Version: 1.0
References: <1223945508-22241-1-git-send-email-glommer@redhat.com>
	<1223945508-22241-5-git-send-email-glommer@redhat.com>
In-Reply-To: <1223945508-22241-5-git-send-email-glommer@redhat.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 4/7] give noaccel a name
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Glauber Costa <glommer@redhat.com>
Cc: aliguori@us.ibm.com, jan.kiszka@siemens.com, jes@sgi.com, qemu-devel@nongnu.org, avi@qumranet.com, dmitry.baryshkov@siemens.com

Glauber Costa wrote:
> otherwise, string comparisons to check for the current accelerator
> may break.
>
> Signed-off-by: Glauber Costa <glommer@redhat.com>
> ---
>  accel.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/accel.c b/accel.c
> index f9618b2..bf3cb73 100644
> --- a/accel.c
> +++ b/accel.c
> @@ -21,7 +21,7 @@ CPUState *noaccel_get_env(void)
>  
>  /* Accelerator wrapper for the no-accel (raw qemu) case */
>  QEMUAccel noaccel = {
> -    .name = NULL,
> +    .name = "noaccel",
>      .cpu_interrupt = accel_nop,
>      .init_env = accel_nop,
>      .get_env = noaccel_get_env,
>   

Maybe "none" or "tcg" or "emulation"?

-- 
Do not meddle in the internals of kernels, for they are subtle and quick to panic.