From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KpmMU-0000Ns-TU for qemu-devel@nongnu.org; Tue, 14 Oct 2008 12:03:06 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KpmMT-0000MO-4Z for qemu-devel@nongnu.org; Tue, 14 Oct 2008 12:03:06 -0400 Received: from [199.232.76.173] (port=37271 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KpmMR-0000M2-Kj for qemu-devel@nongnu.org; Tue, 14 Oct 2008 12:03:04 -0400 Received: from e38.co.us.ibm.com ([32.97.110.159]:60685) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KpmMR-0008Dk-6N for qemu-devel@nongnu.org; Tue, 14 Oct 2008 12:03:03 -0400 Received: from d03relay03.boulder.ibm.com (d03relay03.boulder.ibm.com [9.17.195.228]) by e38.co.us.ibm.com (8.13.1/8.13.1) with ESMTP id m9EG2PqE002037 for ; Tue, 14 Oct 2008 10:02:25 -0600 Received: from d03av04.boulder.ibm.com (d03av04.boulder.ibm.com [9.17.195.170]) by d03relay03.boulder.ibm.com (8.13.8/8.13.8/NCO v9.1) with ESMTP id m9EG2kxs041578 for ; Tue, 14 Oct 2008 10:02:54 -0600 Received: from d03av04.boulder.ibm.com (loopback [127.0.0.1]) by d03av04.boulder.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id m9EG2g6X020720 for ; Tue, 14 Oct 2008 10:02:42 -0600 Message-ID: <48F4C2A0.4060604@us.ibm.com> Date: Tue, 14 Oct 2008 11:02:40 -0500 From: Anthony Liguori MIME-Version: 1.0 References: <1223945508-22241-1-git-send-email-glommer@redhat.com> In-Reply-To: <1223945508-22241-1-git-send-email-glommer@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH 0/7] Update qemu accel Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Glauber Costa Cc: jan.kiszka@siemens.com, jes@sgi.com, qemu-devel@nongnu.org, avi@qumranet.com, dmitry.baryshkov@siemens.com Glauber Costa wrote: > Hi guys, > > I have the following patches that I'm about to commit to the QemuAccel tree, > in case you have no further comments. > > Most of them are small fixes. I particularly don't like one of them: > * check wether kqemu is enabled in open code > > this patch should not exist, but I think this is the simplest solution right now. > > I'm reverting the patch that moves ram allocation to before accel start, since it broke qemu. > This is theorectically needed for kvm, but I think we can rid of this need in KVM. We're > working on it. > > The only new thing in here is the inclusion of a accel_opaque into the CPUState field. > both kqemu and kvm (and possibly others too) have code that fits well inside the CPUState, > and it makes sense to have an opaque to account for them. > > Comments welcome. > Can you post the whole accel series to qemu-devel? I've looked through recent trees and I don't see anything that prevents it from being merged. Regards, Anthony Liguori