[Qemu-devel] Re: [PATCH 03/13] Set mem_io_vaddr on io_read

[Jan Kiszka <jan.kiszka@web.de>]

[-- Attachment #1: Type: text/plain, Size: 964 bytes --]

Glauber Costa wrote:
> On Tue, Oct 14, 2008 at 7:12 AM, Jan Kiszka <jan.kiszka@siemens.com> wrote:
>> Required for read watchpoints.
> can we have a slightly more informative description for the  annotate commands ?

"Analogously to write accesses, we need to save the memory address also
on read accesses in order to support read watchpoints."

Better?
Jan

> 
>> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
>> ---
>>  softmmu_template.h |    1 +
>>  1 file changed, 1 insertion(+)
>>
>> Index: b/softmmu_template.h
>> ===================================================================
>> --- a/softmmu_template.h
>> +++ b/softmmu_template.h
>> @@ -64,6 +64,7 @@ static inline DATA_TYPE glue(io_read, SU
>>         cpu_io_recompile(env, retaddr);
>>     }
>>
>> +    env->mem_io_vaddr = addr;
>>  #if SHIFT <= 2
>>     res = io_mem_read[index][SHIFT](io_mem_opaque[index], physaddr);
>>  #else
>>
>>
>>
>>
> 
> 
> 



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 257 bytes --]