From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Kpo1F-0002m0-RV for qemu-devel@nongnu.org; Tue, 14 Oct 2008 13:49:18 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Kpo1D-0002kl-IC for qemu-devel@nongnu.org; Tue, 14 Oct 2008 13:49:17 -0400 Received: from [199.232.76.173] (port=59614 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Kpo1D-0002kX-6u for qemu-devel@nongnu.org; Tue, 14 Oct 2008 13:49:15 -0400 Received: from fmmailgate01.web.de ([217.72.192.221]:50717) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Kpo1B-00082n-RZ for qemu-devel@nongnu.org; Tue, 14 Oct 2008 13:49:14 -0400 Received: from smtp07.web.de (fmsmtp07.dlan.cinetic.de [172.20.5.215]) by fmmailgate01.web.de (Postfix) with ESMTP id D2582F61D93A for ; Tue, 14 Oct 2008 19:49:12 +0200 (CEST) Received: from [88.64.28.10] (helo=[192.168.1.198]) by smtp07.web.de with asmtp (TLSv1:AES256-SHA:256) (WEB.DE 4.109 #226) id 1Kpo1A-00060G-00 for qemu-devel@nongnu.org; Tue, 14 Oct 2008 19:49:12 +0200 Message-ID: <48F4DB92.8040607@web.de> Date: Tue, 14 Oct 2008 19:49:06 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <20081014091223.932366369@mchn012c.ww002.siemens.net> <20081014091224.934197703@mchn012c.ww002.siemens.net> <5d6222a80810141039m5ae10d6dk5ba35b9883a7c17@mail.gmail.com> In-Reply-To: <5d6222a80810141039m5ae10d6dk5ba35b9883a7c17@mail.gmail.com> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enigBF3B9AF761A0743AC9148BEB" Sender: jan.kiszka@web.de Subject: [Qemu-devel] Re: [PATCH 03/13] Set mem_io_vaddr on io_read Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigBF3B9AF761A0743AC9148BEB Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Glauber Costa wrote: > On Tue, Oct 14, 2008 at 7:12 AM, Jan Kiszka wr= ote: >> Required for read watchpoints. > can we have a slightly more informative description for the annotate c= ommands ? "Analogously to write accesses, we need to save the memory address also on read accesses in order to support read watchpoints." Better? Jan >=20 >> Signed-off-by: Jan Kiszka >> --- >> softmmu_template.h | 1 + >> 1 file changed, 1 insertion(+) >> >> Index: b/softmmu_template.h >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >> --- a/softmmu_template.h >> +++ b/softmmu_template.h >> @@ -64,6 +64,7 @@ static inline DATA_TYPE glue(io_read, SU >> cpu_io_recompile(env, retaddr); >> } >> >> + env->mem_io_vaddr =3D addr; >> #if SHIFT <=3D 2 >> res =3D io_mem_read[index][SHIFT](io_mem_opaque[index], physaddr);= >> #else >> >> >> >> >=20 >=20 >=20 --------------enigBF3B9AF761A0743AC9148BEB Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org iEYEARECAAYFAkj025IACgkQniDOoMHTA+k0mwCff6SR+tVqyAZT2VFUr6Y4xAoG 9lUAn2RgSQaZyUrczAeeq8cyXC2QK8Z4 =R2wg -----END PGP SIGNATURE----- --------------enigBF3B9AF761A0743AC9148BEB--