From: Jan Kiszka <jan.kiszka@web.de>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [PATCH 02/13] Refactor and enhance break/watchpoint API
Date: Tue, 14 Oct 2008 19:53:04 +0200 [thread overview]
Message-ID: <48F4DC80.9000703@web.de> (raw)
In-Reply-To: <5d6222a80810141035k5bc6ba56xb7e6a49d80f6002c@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 593 bytes --]
Glauber Costa wrote:
>> /* Add a watchpoint. */
>> -int cpu_watchpoint_insert(CPUState *env, target_ulong addr, int type)
>> +int cpu_watchpoint_insert(CPUState *env, target_ulong addr, target_ulong len,
>> + int flags, CPUWatchpoint **watchpoint)
>
> Any particular reason you're not simply returning the address of the watchpoint?
> Although I must admit it's a matter of personal taste.
Then I would have to express potential errors as pointer values. I think
I didn't find a precedence for this in QEMU, so I went for the above
interface.
Jan
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 257 bytes --]
next prev parent reply other threads:[~2008-10-14 17:53 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-14 9:12 [Qemu-devel] [PATCH 00/13] Enhance debugging support - 3rd take Jan Kiszka
2008-10-14 9:12 ` [Qemu-devel] [PATCH 01/13] Return appropriate watch message to gdb Jan Kiszka
2008-10-14 9:12 ` [Qemu-devel] [PATCH 02/13] Refactor and enhance break/watchpoint API Jan Kiszka
2008-10-14 17:24 ` Glauber Costa
2008-10-14 17:45 ` [Qemu-devel] " Jan Kiszka
2008-10-14 17:51 ` Glauber Costa
2008-10-14 17:35 ` [Qemu-devel] " Glauber Costa
2008-10-14 17:53 ` Jan Kiszka [this message]
2008-10-14 9:12 ` [Qemu-devel] [PATCH 03/13] Set mem_io_vaddr on io_read Jan Kiszka
2008-10-14 17:39 ` Glauber Costa
2008-10-14 17:49 ` [Qemu-devel] " Jan Kiszka
2008-10-14 9:12 ` [Qemu-devel] [PATCH 04/13] Respect length of watchpoints Jan Kiszka
2008-10-14 17:50 ` Glauber Costa
2008-10-14 18:26 ` [Qemu-devel] " Jan Kiszka
2008-10-14 9:12 ` [Qemu-devel] [PATCH 05/13] Introduce next_cflags Jan Kiszka
2008-10-14 9:12 ` [Qemu-devel] [PATCH 06/13] Switch self-modified code recompilation to next_cflags Jan Kiszka
2008-10-14 9:12 ` [Qemu-devel] [PATCH 07/13] Restore pc on watchpoint hits Jan Kiszka
2008-10-14 9:12 ` [Qemu-devel] [PATCH 08/13] Remove premature memop TB terminations Jan Kiszka
2008-10-14 9:12 ` [Qemu-devel] [PATCH 09/13] qemu: gdbstub: manage CPUs as threads Jan Kiszka
2008-10-14 9:12 ` [Qemu-devel] [PATCH 10/13] Introduce BP_WATCHPOINT_HIT flag Jan Kiszka
2008-10-14 9:12 ` [Qemu-devel] [PATCH 11/13] Add debug exception hook Jan Kiszka
2008-10-14 9:12 ` [Qemu-devel] [PATCH 12/13] Introduce BP_CPU as a breakpoint type Jan Kiszka
2008-10-14 9:12 ` [Qemu-devel] [PATCH 13/13] x86: Debug register emulation Jan Kiszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48F4DC80.9000703@web.de \
--to=jan.kiszka@web.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).