From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Kpo50-0004hI-6L for qemu-devel@nongnu.org; Tue, 14 Oct 2008 13:53:10 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Kpo4y-0004gC-KA for qemu-devel@nongnu.org; Tue, 14 Oct 2008 13:53:09 -0400 Received: from [199.232.76.173] (port=59759 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Kpo4y-0004g3-CQ for qemu-devel@nongnu.org; Tue, 14 Oct 2008 13:53:08 -0400 Received: from fmmailgate02.web.de ([217.72.192.227]:50494) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Kpo4x-0000SG-Lp for qemu-devel@nongnu.org; Tue, 14 Oct 2008 13:53:08 -0400 Received: from smtp07.web.de (fmsmtp07.dlan.cinetic.de [172.20.5.215]) by fmmailgate02.web.de (Postfix) with ESMTP id AE4C4F32F94A for ; Tue, 14 Oct 2008 19:53:05 +0200 (CEST) Received: from [88.64.28.10] (helo=[192.168.1.198]) by smtp07.web.de with asmtp (TLSv1:AES256-SHA:256) (WEB.DE 4.109 #226) id 1Kpo4v-0007Pv-00 for qemu-devel@nongnu.org; Tue, 14 Oct 2008 19:53:05 +0200 Message-ID: <48F4DC80.9000703@web.de> Date: Tue, 14 Oct 2008 19:53:04 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <20081014091223.932366369@mchn012c.ww002.siemens.net> <20081014091224.774875732@mchn012c.ww002.siemens.net> <5d6222a80810141035k5bc6ba56xb7e6a49d80f6002c@mail.gmail.com> In-Reply-To: <5d6222a80810141035k5bc6ba56xb7e6a49d80f6002c@mail.gmail.com> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig426D8A351CE2038454193567" Sender: jan.kiszka@web.de Subject: [Qemu-devel] Re: [PATCH 02/13] Refactor and enhance break/watchpoint API Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig426D8A351CE2038454193567 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Glauber Costa wrote: >> /* Add a watchpoint. */ >> -int cpu_watchpoint_insert(CPUState *env, target_ulong addr, int type)= >> +int cpu_watchpoint_insert(CPUState *env, target_ulong addr, target_ul= ong len, >> + int flags, CPUWatchpoint **watchpoint) >=20 > Any particular reason you're not simply returning the address of the wa= tchpoint? > Although I must admit it's a matter of personal taste. Then I would have to express potential errors as pointer values. I think I didn't find a precedence for this in QEMU, so I went for the above interface. Jan --------------enig426D8A351CE2038454193567 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org iEYEARECAAYFAkj03IAACgkQniDOoMHTA+k1JwCfWyV/QtHk8N9IP1l9YGWgQllA n0YAn0sRqizmmooQGzX4fDky4UjnY6vo =1vSR -----END PGP SIGNATURE----- --------------enig426D8A351CE2038454193567--