[Qemu-devel] [5486] Define O_DSYNC as O_SYNC if necessary.

[Qemu-devel] [5486] Define O_DSYNC as O_SYNC if necessary.

[Anthony Liguori]

Revision: 5486
          http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=5486
Author:   aliguori
Date:     2008-10-14 18:00:38 +0000 (Tue, 14 Oct 2008)

Log Message:
-----------
Define O_DSYNC as O_SYNC if necessary.

O_DSYNC isn't available on OS X.

Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>

Modified Paths:
--------------
    trunk/block-raw-posix.c

Modified: trunk/block-raw-posix.c
===================================================================
--- trunk/block-raw-posix.c	2008-10-14 14:42:54 UTC (rev 5485)
+++ trunk/block-raw-posix.c	2008-10-14 18:00:38 UTC (rev 5486)
@@ -73,6 +73,11 @@
 #define DEBUG_BLOCK_PRINT(formatCstr, args...)
 #endif
 
+/* OS X does not have O_DSYNC */
+#ifndef O_DSYNC
+#define O_SYNC
+#endif
+
 /* Approximate O_DIRECT with O_DSYNC if O_DIRECT isn't available */
 #ifndef O_DIRECT
 #define O_DIRECT O_DSYNC

Re: [Qemu-devel] [5486] Define O_DSYNC as O_SYNC if necessary.

[Robert Riebisch]

Anthony Liguori wrote:

> Define O_DSYNC as O_SYNC if necessary.

...

> +/* OS X does not have O_DSYNC */
> +#ifndef O_DSYNC
> +#define O_SYNC
> +#endif
> +

Not "+#define O_DSYNC O_SYNC"?

Robert Riebisch
-- 
BTTR Software
http://www.bttr-software.de/

Re: [Qemu-devel] [5486] Define O_DSYNC as O_SYNC if necessary.

[Anthony Liguori]

Robert Riebisch wrote:
> Anthony Liguori wrote:
>
>   
>> Define O_DSYNC as O_SYNC if necessary.
>>     
>
> ...
>
>   
>> +/* OS X does not have O_DSYNC */
>> +#ifndef O_DSYNC
>> +#define O_SYNC
>> +#endif
>> +
>>     
>
> Not "+#define O_DSYNC O_SYNC"?
>   

Sigh, sorry about that.  Thanks for catching that.

Regards,

Anthony Liguori

> Robert Riebisch
>   

Re: [Qemu-devel] [5486] Define O_DSYNC as O_SYNC if necessary.

[Laurent Vivier]

Le 14 oct. 08 à 20:12, Robert Riebisch a écrit :

> Anthony Liguori wrote:
>
>> Define O_DSYNC as O_SYNC if necessary.
>
> ...
>
>> +/* OS X does not have O_DSYNC */
>> +#ifndef O_DSYNC
>> +#define O_SYNC
>> +#endif
>> +
>
> Not "+#define O_DSYNC O_SYNC"?

OS X does not have O_SYNC too...

You can use fcntl() with F_NOCACHE to emulate O_DIRECT, I think.

BSD is not POSIX ;-)

Regards,
Laurent

----------------------- Laurent Vivier ----------------------
"The best way to predict the future is to invent it."
- Alan Kay

Re: [Qemu-devel] [5486] Define O_DSYNC as O_SYNC if necessary.

[Laurent Vivier]

Le 14 oct. 08 à 20:21, Laurent Vivier a écrit :

>
> Le 14 oct. 08 à 20:12, Robert Riebisch a écrit :
>
>> Anthony Liguori wrote:
>>
>>> Define O_DSYNC as O_SYNC if necessary.
>>
>> ...
>>
>>> +/* OS X does not have O_DSYNC */
>>> +#ifndef O_DSYNC
>>> +#define O_SYNC
>>> +#endif
>>> +
>>
>> Not "+#define O_DSYNC O_SYNC"?
>
> OS X does not have O_SYNC too...


Sorry, I'm wrong, it has O_SYNC, but "man open" doesn't give it...

Laurent
----------------------- Laurent Vivier ----------------------
"The best way to predict the future is to invent it."
- Alan Kay

Re: [Qemu-devel] [5486] Define O_DSYNC as O_SYNC if necessary.

[Anthony Liguori]

Laurent Vivier wrote:
> Sorry, I'm wrong, it has O_SYNC, but "man open" doesn't give it...

Whew.  I was worried there for a moment :-)

Regards,

Anthony Liguori

> Laurent
> ----------------------- Laurent Vivier ----------------------
> "The best way to predict the future is to invent it."
> - Alan Kay
>
>
>
>
>
>
>