From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KqCxS-0005Ic-Uf for qemu-devel@nongnu.org; Wed, 15 Oct 2008 16:27:03 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KqCxS-0005Hn-3c for qemu-devel@nongnu.org; Wed, 15 Oct 2008 16:27:02 -0400 Received: from [199.232.76.173] (port=55874 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KqCxR-0005HZ-SG for qemu-devel@nongnu.org; Wed, 15 Oct 2008 16:27:01 -0400 Received: from e35.co.us.ibm.com ([32.97.110.153]:35910) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KqCxR-000693-Ej for qemu-devel@nongnu.org; Wed, 15 Oct 2008 16:27:01 -0400 Received: from d03relay04.boulder.ibm.com (d03relay04.boulder.ibm.com [9.17.195.106]) by e35.co.us.ibm.com (8.13.8/8.13.8) with ESMTP id m9FKQt1O012893 for ; Wed, 15 Oct 2008 16:26:55 -0400 Received: from d03av01.boulder.ibm.com (d03av01.boulder.ibm.com [9.17.195.167]) by d03relay04.boulder.ibm.com (8.13.8/8.13.8/NCO v9.1) with ESMTP id m9FKPLLV174772 for ; Wed, 15 Oct 2008 14:25:22 -0600 Received: from d03av01.boulder.ibm.com (loopback [127.0.0.1]) by d03av01.boulder.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id m9FKPLpJ009464 for ; Wed, 15 Oct 2008 14:25:21 -0600 Message-ID: <48F651B0.8030502@us.ibm.com> Date: Wed, 15 Oct 2008 15:25:20 -0500 From: Anthony Liguori MIME-Version: 1.0 References: <1224107718-19128-1-git-send-email-glommer@redhat.com> <1224107718-19128-6-git-send-email-glommer@redhat.com> In-Reply-To: <1224107718-19128-6-git-send-email-glommer@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH 05/21] turn info kqemu into generic info accelerator Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Glauber Costa Cc: jan.kiszka@siemens.com, jes@sgi.com, qemu-devel@nongnu.org, avi@qumranet.com, Glauber Costa , dmitry.baryshkov@siemens.com Glauber Costa wrote: > From: Glauber Costa > > Yet another accel field: info. > From this point on, "info kqemu" is no more. "info accelerator" should > be used instead. > > Signed-off-by: Glauber Costa > --- > accel.c | 6 ++++++ > accel.h | 6 ++++++ > kqemu.c | 24 ++++++++++++++++++++++++ > monitor.c | 36 +++++++++++++----------------------- > 4 files changed, 49 insertions(+), 23 deletions(-) > > diff --git a/accel.c b/accel.c > index 6776244..466fe67 100644 > --- a/accel.c > +++ b/accel.c > @@ -8,6 +8,11 @@ int _accel_nop(void) > return 0; > } > > +int noaccel_info(CPUState *env, char *buf) > +{ > + return sprintf(buf, "no accelerator present.\n"); > sprintf() is evil and never should be used. You should refactor this patch for the info callback to take a buffer size and use snprintf(). Regards, Anthony Liguori