From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1KqD2c-00039J-Hv
	for qemu-devel@nongnu.org; Wed, 15 Oct 2008 16:32:22 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1KqD2b-00037K-ID
	for qemu-devel@nongnu.org; Wed, 15 Oct 2008 16:32:22 -0400
Received: from [199.232.76.173] (port=60877 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1KqD2b-000377-E3
	for qemu-devel@nongnu.org; Wed, 15 Oct 2008 16:32:21 -0400
Received: from e33.co.us.ibm.com ([32.97.110.151]:34115)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <aliguori@us.ibm.com>) id 1KqD2b-0006rT-01
	for qemu-devel@nongnu.org; Wed, 15 Oct 2008 16:32:21 -0400
Received: from d03relay02.boulder.ibm.com (d03relay02.boulder.ibm.com
	[9.17.195.227])
	by e33.co.us.ibm.com (8.13.8/8.13.8) with ESMTP id m9FKWIGT013547
	for <qemu-devel@nongnu.org>; Wed, 15 Oct 2008 16:32:18 -0400
Received: from d03av04.boulder.ibm.com (d03av04.boulder.ibm.com [9.17.195.170])
	by d03relay02.boulder.ibm.com (8.13.8/8.13.8/NCO v9.1) with ESMTP id
	m9FKW6vU150962
	for <qemu-devel@nongnu.org>; Wed, 15 Oct 2008 14:32:10 -0600
Received: from d03av04.boulder.ibm.com (loopback [127.0.0.1])
	by d03av04.boulder.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id
	m9FKW6t8005289
	for <qemu-devel@nongnu.org>; Wed, 15 Oct 2008 14:32:06 -0600
Message-ID: <48F65345.1070404@us.ibm.com>
Date: Wed, 15 Oct 2008 15:32:05 -0500
From: Anthony Liguori <aliguori@us.ibm.com>
MIME-Version: 1.0
References: <1224107718-19128-1-git-send-email-glommer@redhat.com>
	<1224107718-19128-9-git-send-email-glommer@redhat.com>
In-Reply-To: <1224107718-19128-9-git-send-email-glommer@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 08/21] move disabling code to kqemu.c
	instead of vl.c
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Glauber Costa <glommer@redhat.com>
Cc: jan.kiszka@siemens.com, jes@sgi.com, qemu-devel@nongnu.org, avi@qumranet.com, Glauber Costa <gcosta@redhat.com>, dmitry.baryshkov@siemens.com

Glauber Costa wrote:
> From: Glauber Costa <gcosta@redhat.com>
>
> kqemu is not smp. So instead of testing in vl.c, do the test in kqemu.c,
> and just refuse to start if smp_cpus > 1.
>   

Maybe the start accelerator should be passed the number of cpus instead 
of relying on an extern variable?

Regards,

Anthony Liguori