qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Anthony Liguori <anthony@codemonkey.ws>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] Implement "info chardev" command.
Date: Tue, 21 Oct 2008 10:03:27 -0500	[thread overview]
Message-ID: <48FDEF3F.70807@codemonkey.ws> (raw)
In-Reply-To: <48F75657.7020901@redhat.com>

Gerd Hoffmann wrote:
>   Hi,
>
> This patch makes qemu keep track of the character devices in use and
> implements a "info chardev" monitor command to print a list.
>   

Is it better to enumerate all chardevs or to provide info functions for 
each type of chardev (i.e. 'info serial', 'info parallel').  I don't 
have a strong feeling either way.

The only thing I'd suggest about this patch is that if you're going to 
print pty:/dev/pty/3, then you should also support that syntax for 
specifying a pty.  Otherwise, there's a lack of symmetry.

Regards,

Anthony Liguori

> please apply,
>   Gerd
>   

  reply	other threads:[~2008-10-21 15:03 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-16 14:57 [Qemu-devel] [PATCH] Implement "info chardev" command Gerd Hoffmann
2008-10-21 15:03 ` Anthony Liguori [this message]
2008-10-22  8:20   ` Gerd Hoffmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48FDEF3F.70807@codemonkey.ws \
    --to=anthony@codemonkey.ws \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).