From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KsIlo-0006Or-7W for qemu-devel@nongnu.org; Tue, 21 Oct 2008 11:03:40 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KsIlj-0006Mo-O1 for qemu-devel@nongnu.org; Tue, 21 Oct 2008 11:03:39 -0400 Received: from [199.232.76.173] (port=49893 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KsIlj-0006Mh-Fg for qemu-devel@nongnu.org; Tue, 21 Oct 2008 11:03:35 -0400 Received: from yw-out-1718.google.com ([74.125.46.153]:3969) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KsIli-0006Da-PG for qemu-devel@nongnu.org; Tue, 21 Oct 2008 11:03:35 -0400 Received: by yw-out-1718.google.com with SMTP id 6so391420ywa.82 for ; Tue, 21 Oct 2008 08:03:31 -0700 (PDT) Message-ID: <48FDEF3F.70807@codemonkey.ws> Date: Tue, 21 Oct 2008 10:03:27 -0500 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] Implement "info chardev" command. References: <48F75657.7020901@redhat.com> In-Reply-To: <48F75657.7020901@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Gerd Hoffmann wrote: > Hi, > > This patch makes qemu keep track of the character devices in use and > implements a "info chardev" monitor command to print a list. > Is it better to enumerate all chardevs or to provide info functions for each type of chardev (i.e. 'info serial', 'info parallel'). I don't have a strong feeling either way. The only thing I'd suggest about this patch is that if you're going to print pty:/dev/pty/3, then you should also support that syntax for specifying a pty. Otherwise, there's a lack of symmetry. Regards, Anthony Liguori > please apply, > Gerd >