From: Richard Henderson <richard.henderson@linaro.org>
To: Yeqi Fu <fufuyqqqqqq@gmail.com>, alex.bennee@linaro.org
Cc: qemu-devel@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>,
Eduardo Habkost <eduardo@habkost.net>
Subject: Re: [RFC v2 3/6] target/i386: Add native library calls
Date: Wed, 7 Jun 2023 12:19:37 -0700 [thread overview]
Message-ID: <48a22e2f-bb7e-e459-0144-721f9e580a74@linaro.org> (raw)
In-Reply-To: <20230607164750.829586-4-fufuyqqqqqq@gmail.com>
On 6/7/23 09:47, Yeqi Fu wrote:
> + /* One unknown opcode for native call */
> +#if defined(CONFIG_USER_ONLY) && defined(CONFIG_USER_NATIVE_CALL)
> + case 0x1ff:
> + uint16_t sig = x86_lduw_code(env, s);
> + switch (sig) {
> + case NATIVE_MEMCPY:
> + gen_helper_native_memcpy(cpu_env);
> + break;
> + case NATIVE_MEMSET:
> + gen_helper_native_memset(cpu_env);
> + break;
> + case NATIVE_MEMCMP:
> + gen_helper_native_memcmp(cpu_env);
> + break;
> + default:
> + goto unknown_op;
> + }
> + break;
> +#endif
This bit of code must be protected by native_calls_enabled() or some such, as we do with
semihosting_enabled().
Which means that patch 6 should come before this, so that native_calls_enabled() can be
true if and only if "-native-bypass" is given.
r~
next prev parent reply other threads:[~2023-06-07 19:20 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-07 16:47 [RFC v2 0/6] Native Library Calls Yeqi Fu
2023-06-07 16:47 ` [RFC v2 1/6] build: Add configure options for native calls Yeqi Fu
2023-06-09 5:08 ` Manos Pitsidianakis
2023-06-12 11:54 ` Alex Bennée
2023-06-12 13:02 ` Alex Bennée
2023-06-07 16:47 ` [RFC v2 2/6] Add the libnative library Yeqi Fu
2023-06-15 7:59 ` Alex Bennée
2023-06-07 16:47 ` [RFC v2 3/6] target/i386: Add native library calls Yeqi Fu
2023-06-07 19:08 ` Richard Henderson
2023-06-07 19:19 ` Richard Henderson [this message]
2023-06-07 16:47 ` [RFC v2 4/6] target/mips: " Yeqi Fu
2023-06-07 19:15 ` Richard Henderson
2023-06-07 16:47 ` [RFC v2 5/6] target/arm: " Yeqi Fu
2023-06-07 16:47 ` [RFC v2 6/6] linux-user: Add '-native-bypass' option Yeqi Fu
2023-06-09 5:24 ` Manos Pitsidianakis
2023-06-12 13:06 ` Alex Bennée
2023-06-12 13:23 ` Alex Bennée
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48a22e2f-bb7e-e459-0144-721f9e580a74@linaro.org \
--to=richard.henderson@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=eduardo@habkost.net \
--cc=fufuyqqqqqq@gmail.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).