qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: riku.voipio@linaro.org
To: qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>
Subject: [Qemu-devel] [PULL 10/24] linux-user: Fix wrong type used for argument to rt_sigqueueinfo
Date: Fri, 24 Jun 2016 12:53:05 +0300	[thread overview]
Message-ID: <48a32aaa67a77a0fba96500f489b6018a38b36bd.1466760944.git.riku.voipio@linaro.org> (raw)
In-Reply-To: <cover.1466760944.git.riku.voipio@linaro.org>

From: Peter Maydell <peter.maydell@linaro.org>

The third argument to the rt_sigqueueinfo syscall is a pointer to
a siginfo_t, not a pointer to a sigset_t. Fix the error in the
arguments to lock_user(), which meant that we would not have
detected some faults that we should.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Laurent Vivier <laurent@vivier.eu>
Signed-off-by: Riku Voipio <riku.voipio@linaro.org>
---
 linux-user/syscall.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index 95eafeb..686ebfb 100644
--- a/linux-user/syscall.c
+++ b/linux-user/syscall.c
@@ -7876,8 +7876,11 @@ abi_long do_syscall(void *cpu_env, int num, abi_long arg1,
     case TARGET_NR_rt_sigqueueinfo:
         {
             siginfo_t uinfo;
-            if (!(p = lock_user(VERIFY_READ, arg3, sizeof(target_sigset_t), 1)))
+
+            p = lock_user(VERIFY_READ, arg3, sizeof(target_siginfo_t), 1);
+            if (!p) {
                 goto efault;
+            }
             target_to_host_siginfo(&uinfo, p);
             unlock_user(p, arg1, 0);
             ret = get_errno(sys_rt_sigqueueinfo(arg1, arg2, &uinfo));
-- 
2.1.4

  parent reply	other threads:[~2016-06-24  9:53 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-24  9:52 [Qemu-devel] [PULL 00/24] linux-user changes riku.voipio
2016-06-24  9:52 ` [Qemu-devel] [PULL 01/24] linux-user: Avoid possible misalignment in host_to_target_siginfo() riku.voipio
2016-06-24  9:52 ` [Qemu-devel] [PULL 02/24] linux-user: Use __get_user() and __put_user() to handle structs in do_fcntl() riku.voipio
2016-06-24  9:52 ` [Qemu-devel] [PULL 03/24] linux-user: Use safe_syscall wrapper for fcntl riku.voipio
2016-06-24  9:52 ` [Qemu-devel] [PULL 04/24] linux-user: Don't use sigfillset() on uc->uc_sigmask riku.voipio
2016-06-24  9:53 ` [Qemu-devel] [PULL 05/24] configure: Don't override ARCH=unknown if enabling TCI riku.voipio
2016-06-24  9:53 ` [Qemu-devel] [PULL 06/24] configure: Don't allow user-only targets for unknown CPU architectures riku.voipio
2016-06-24  9:53 ` [Qemu-devel] [PULL 07/24] user-exec: Delete now-unused hppa and m68k cpu_signal_handler() code riku.voipio
2016-06-24  9:53 ` [Qemu-devel] [PULL 08/24] user-exec: Remove unused code for OSX hosts riku.voipio
2016-06-24  9:53 ` [Qemu-devel] [PULL 09/24] linux-user: Create a hostdep.h for each host architecture riku.voipio
2016-06-24  9:53 ` riku.voipio [this message]
2016-06-24  9:53 ` [Qemu-devel] [PULL 11/24] linux-user: Support F_GETPIPE_SZ and F_SETPIPE_SZ fcntls riku.voipio
2016-06-24  9:53 ` [Qemu-devel] [PULL 12/24] linux-user: add socketcall() strace riku.voipio
2016-06-24  9:53 ` [Qemu-devel] [PULL 13/24] linux-user: add socket() strace riku.voipio
2016-06-24  9:53 ` [Qemu-devel] [PULL 14/24] linux-user: fix clone() strace riku.voipio
2016-06-24  9:53 ` [Qemu-devel] [PULL 15/24] linux-user: update get_thread_area/set_thread_area strace riku.voipio
2016-06-24  9:53 ` [Qemu-devel] [PULL 16/24] linux-user: add missing return in netlink switch statement riku.voipio
2016-06-24  9:53 ` [Qemu-devel] [PULL 17/24] linux-user: fd_trans_host_to_target_data() must process only received data riku.voipio
2016-06-24  9:53 ` [Qemu-devel] [PULL 18/24] linux-user: don't swap NLMSG_DATA() fields riku.voipio
2016-06-24  9:53 ` [Qemu-devel] [PULL 19/24] linux-user: fix x86_64 safe_syscall riku.voipio
2016-06-24  9:53 ` [Qemu-devel] [PULL 20/24] linux-user: Provide safe_syscall for i386 riku.voipio
2016-06-24  9:53 ` [Qemu-devel] [PULL 21/24] linux-user: Provide safe_syscall for arm riku.voipio
2016-06-24  9:53 ` [Qemu-devel] [PULL 22/24] linux-user: Provide safe_syscall for aarch64 riku.voipio
2016-06-24  9:53 ` [Qemu-devel] [PULL 23/24] linux-user: Provide safe_syscall for s390x riku.voipio
2016-06-24  9:53 ` [Qemu-devel] [PULL 24/24] linux-user: Provide safe_syscall for ppc64 riku.voipio
2016-06-24 13:36 ` [Qemu-devel] [PULL 00/24] linux-user changes Peter Maydell
2016-06-26 10:34   ` Riku Voipio

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48a32aaa67a77a0fba96500f489b6018a38b36bd.1466760944.git.riku.voipio@linaro.org \
    --to=riku.voipio@linaro.org \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).