From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Bernhard Beschow <shentey@gmail.com>, qemu-devel@nongnu.org
Cc: Richard Henderson <richard.henderson@linaro.org>,
"Michael S. Tsirkin" <mst@redhat.com>,
Ani Sinha <ani@anisinha.ca>,
Eduardo Habkost <eduardo@habkost.net>,
Igor Mammedov <imammedo@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Laurent Vivier <lvivier@redhat.com>,
Marcel Apfelbaum <marcel.apfelbaum@gmail.com>,
Sunil Muthuswamy <sunilmut@microsoft.com>,
Thomas Huth <thuth@redhat.com>
Subject: Re: [PATCH 09/12] hw/i386/ich9: Remove redundant GSI_NUM_PINS
Date: Mon, 27 Feb 2023 12:56:09 +0100 [thread overview]
Message-ID: <48a7a544-a149-eaca-71d4-f05d58e84922@linaro.org> (raw)
In-Reply-To: <20230213173033.98762-10-shentey@gmail.com>
On 13/2/23 18:30, Bernhard Beschow wrote:
> Most code uses IOAPIC_NUM_PINS. The only place where GSI_NUM_PINS defines
> the size of an array is ICH9LPCState::gsi which needs to match
> IOAPIC_NUM_PINS. Remove GSI_NUM_PINS for consistency.
>
> Signed-off-by: Bernhard Beschow <shentey@gmail.com>
> ---
> include/hw/i386/ich9.h | 2 +-
> include/hw/i386/x86.h | 1 -
> hw/i386/pc.c | 6 +++---
> hw/i386/pc_q35.c | 3 ++-
> hw/isa/lpc_ich9.c | 2 +-
> 5 files changed, 7 insertions(+), 7 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
next prev parent reply other threads:[~2023-02-27 11:56 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-13 17:30 [PATCH 00/12] ICH9 cleanup Bernhard Beschow
2023-02-13 17:30 ` [PATCH 01/12] hw/i386/ich9: Rename Q35_MASK to ICH9_MASK Bernhard Beschow
2023-02-27 11:51 ` Philippe Mathieu-Daudé
2023-02-13 17:30 ` [PATCH 02/12] hw/isa/lpc_ich9: Unexport PIRQ functions Bernhard Beschow
2023-02-27 11:51 ` Philippe Mathieu-Daudé
2023-02-13 17:30 ` [PATCH 03/12] hw/isa/lpc_ich9: Eliminate ICH9LPCState::isa_bus Bernhard Beschow
2023-02-27 11:51 ` Philippe Mathieu-Daudé
2023-02-13 17:30 ` [PATCH 04/12] hw/i2c/smbus_ich9: Move ich9_smb_set_irq() in front of ich9_smbus_realize() Bernhard Beschow
2023-02-27 11:52 ` Philippe Mathieu-Daudé
2023-02-13 17:30 ` [PATCH 05/12] hw/i2c/smbus_ich9: Inline ich9_smb_init() and remove it Bernhard Beschow
2023-02-18 20:25 ` Corey Minyard
2023-02-19 13:45 ` Philippe Mathieu-Daudé
2023-02-19 14:21 ` Corey Minyard
2023-02-27 11:53 ` Philippe Mathieu-Daudé
2023-02-27 19:34 ` Corey Minyard
2023-02-13 17:30 ` [PATCH 06/12] hw/i386/pc_q35: Allow for setting properties before realizing TYPE_ICH9_LPC_DEVICE Bernhard Beschow
2023-02-27 11:53 ` Philippe Mathieu-Daudé
2023-02-13 17:30 ` [PATCH 07/12] hw/isa/lpc_ich9: Connect pm stuff to lpc internally Bernhard Beschow
2023-02-27 11:55 ` Philippe Mathieu-Daudé
2023-02-13 17:30 ` [PATCH 08/12] hw/isa/lpc_ich9: Remove redundant ich9_lpc_reset() invocation Bernhard Beschow
2023-02-27 11:55 ` Philippe Mathieu-Daudé
2023-02-13 17:30 ` [PATCH 09/12] hw/i386/ich9: Remove redundant GSI_NUM_PINS Bernhard Beschow
2023-02-27 11:56 ` Philippe Mathieu-Daudé [this message]
2023-02-13 17:30 ` [PATCH 10/12] hw: Move ioapic*.h to intc/ Bernhard Beschow
2023-02-27 12:07 ` Philippe Mathieu-Daudé
2023-02-13 17:30 ` [PATCH 11/12] hw/i386/ich9: Clean up includes Bernhard Beschow
2023-02-27 12:09 ` Philippe Mathieu-Daudé
2023-02-13 17:30 ` [PATCH 12/12] hw: Move ich9.h to southbridge/ Bernhard Beschow
2023-02-27 11:56 ` Philippe Mathieu-Daudé
2023-02-27 12:22 ` Philippe Mathieu-Daudé
2023-03-01 21:31 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48a7a544-a149-eaca-71d4-f05d58e84922@linaro.org \
--to=philmd@linaro.org \
--cc=ani@anisinha.ca \
--cc=eduardo@habkost.net \
--cc=imammedo@redhat.com \
--cc=lvivier@redhat.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=shentey@gmail.com \
--cc=sunilmut@microsoft.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).