* [Qemu-devel] [PATCH] shippable: fix build
@ 2019-02-20 10:45 Paolo Bonzini
2019-02-20 16:37 ` Alex Bennée
2019-02-20 17:19 ` Philippe Mathieu-Daudé
0 siblings, 2 replies; 8+ messages in thread
From: Paolo Bonzini @ 2019-02-20 10:45 UTC (permalink / raw)
To: qemu-devel; +Cc: alex.bennee
It looks like something in netmap has changed and compilation fails:
install -D libnetmap.a //usr/local/lib/libnetmap.a
install: cannot stat libnetmap.a: No such file or directory
Add an explicit "make" step to fix it.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
tests/docker/dockerfiles/debian-amd64.docker | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/docker/dockerfiles/debian-amd64.docker b/tests/docker/dockerfiles/debian-amd64.docker
index 954fcf9606..df79f35a46 100644
--- a/tests/docker/dockerfiles/debian-amd64.docker
+++ b/tests/docker/dockerfiles/debian-amd64.docker
@@ -33,7 +33,7 @@ RUN DEBIAN_FRONTEND=noninteractive eatmydata \
apt-get install -y --no-install-recommends \
linux-headers-amd64
RUN git clone https://github.com/luigirizzo/netmap.git /usr/src/netmap
-RUN cd /usr/src/netmap/LINUX && ./configure --no-drivers --no-apps --kernel-dir=$(ls -d /usr/src/linux-headers-*-amd64) && make install
+RUN cd /usr/src/netmap/LINUX && ./configure --no-drivers --no-apps --kernel-dir=$(ls -d /usr/src/linux-headers-*-amd64) && make && make install
ENV QEMU_CONFIGURE_OPTS --enable-netmap
RUN ldconfig
--
2.20.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [Qemu-devel] [PATCH] shippable: fix build
2019-02-20 10:45 [Qemu-devel] [PATCH] shippable: fix build Paolo Bonzini
@ 2019-02-20 16:37 ` Alex Bennée
2019-02-20 17:24 ` Philippe Mathieu-Daudé
2019-02-20 17:19 ` Philippe Mathieu-Daudé
1 sibling, 1 reply; 8+ messages in thread
From: Alex Bennée @ 2019-02-20 16:37 UTC (permalink / raw)
To: Paolo Bonzini; +Cc: qemu-devel
Paolo Bonzini <pbonzini@redhat.com> writes:
> It looks like something in netmap has changed and compilation fails:
>
> install -D libnetmap.a //usr/local/lib/libnetmap.a
> install: cannot stat libnetmap.a: No such file or directory
>
> Add an explicit "make" step to fix it.
I took an alternate approach as tracking another projects master seems
like a bad idea:
tests/docker: peg netmap code to a specific version
Tracking head is always going to be at the whims of the upstream.
Let's use a defined release so things don't magically change under us.
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
1 file changed, 1 insertion(+)
tests/docker/dockerfiles/debian-amd64.docker | 1 +
modified tests/docker/dockerfiles/debian-amd64.docker
@@ -33,6 +33,7 @@ RUN DEBIAN_FRONTEND=noninteractive eatmydata \
apt-get install -y --no-install-recommends \
linux-headers-amd64
RUN git clone https://github.com/luigirizzo/netmap.git /usr/src/netmap
+RUN cd /usr/src/netmap && git checkout v11.3
RUN cd /usr/src/netmap/LINUX && ./configure --no-drivers --no-apps --kernel-dir=$(ls -d /usr/src/linux-headers-*-amd64) && make install
ENV QEMU_CONFIGURE_OPTS --enable-netmap
<snip>
--
Alex Bennée
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Qemu-devel] [PATCH] shippable: fix build
2019-02-20 10:45 [Qemu-devel] [PATCH] shippable: fix build Paolo Bonzini
2019-02-20 16:37 ` Alex Bennée
@ 2019-02-20 17:19 ` Philippe Mathieu-Daudé
1 sibling, 0 replies; 8+ messages in thread
From: Philippe Mathieu-Daudé @ 2019-02-20 17:19 UTC (permalink / raw)
To: Paolo Bonzini, qemu-devel; +Cc: alex.bennee
Hi Paolo,
Please also Cc reviewers :)
On 2/20/19 11:45 AM, Paolo Bonzini wrote:
> It looks like something in netmap has changed and compilation fails:
Partly my fault, I had the intention to add a git 'stable' tag for
reproducible builds [*] but forgot to add to my TODO list :/
[*] https://lists.gnu.org/archive/html/qemu-devel/2019-01/msg02028.html
>
> install -D libnetmap.a //usr/local/lib/libnetmap.a
> install: cannot stat libnetmap.a: No such file or directory
>
> Add an explicit "make" step to fix it.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> tests/docker/dockerfiles/debian-amd64.docker | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/docker/dockerfiles/debian-amd64.docker b/tests/docker/dockerfiles/debian-amd64.docker
> index 954fcf9606..df79f35a46 100644
> --- a/tests/docker/dockerfiles/debian-amd64.docker
> +++ b/tests/docker/dockerfiles/debian-amd64.docker
> @@ -33,7 +33,7 @@ RUN DEBIAN_FRONTEND=noninteractive eatmydata \
> apt-get install -y --no-install-recommends \
> linux-headers-amd64
> RUN git clone https://github.com/luigirizzo/netmap.git /usr/src/netmap
So the fix would be:
- RUN git clone https://github.com/luigirizzo/netmap.git /usr/src/netmap
+ RUN git clone https://github.com/luigirizzo/netmap.git /usr/src/netmap
&& \
git checkout v11.4
> -RUN cd /usr/src/netmap/LINUX && ./configure --no-drivers --no-apps --kernel-dir=$(ls -d /usr/src/linux-headers-*-amd64) && make install
> +RUN cd /usr/src/netmap/LINUX && ./configure --no-drivers --no-apps --kernel-dir=$(ls -d /usr/src/linux-headers-*-amd64) && make && make install
Your change doesn't hurt.
> ENV QEMU_CONFIGURE_OPTS --enable-netmap
>
> RUN ldconfig
>
Regards,
Phil.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Qemu-devel] [PATCH] shippable: fix build
2019-02-20 16:37 ` Alex Bennée
@ 2019-02-20 17:24 ` Philippe Mathieu-Daudé
2019-02-20 17:45 ` Alex Bennée
0 siblings, 1 reply; 8+ messages in thread
From: Philippe Mathieu-Daudé @ 2019-02-20 17:24 UTC (permalink / raw)
To: Alex Bennée, Paolo Bonzini; +Cc: qemu-devel
On 2/20/19 5:37 PM, Alex Bennée wrote:
> Paolo Bonzini <pbonzini@redhat.com> writes:
>
>> It looks like something in netmap has changed and compilation fails:
>>
>> install -D libnetmap.a //usr/local/lib/libnetmap.a
>> install: cannot stat libnetmap.a: No such file or directory
>>
>> Add an explicit "make" step to fix it.
>
> I took an alternate approach as tracking another projects master seems
> like a bad idea:
>
> tests/docker: peg netmap code to a specific version
>
> Tracking head is always going to be at the whims of the upstream.
> Let's use a defined release so things don't magically change under us.
Oh now I see your reply...
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
>
> 1 file changed, 1 insertion(+)
> tests/docker/dockerfiles/debian-amd64.docker | 1 +
>
> modified tests/docker/dockerfiles/debian-amd64.docker
> @@ -33,6 +33,7 @@ RUN DEBIAN_FRONTEND=noninteractive eatmydata \
> apt-get install -y --no-install-recommends \
> linux-headers-amd64
> RUN git clone https://github.com/luigirizzo/netmap.git /usr/src/netmap
> +RUN cd /usr/src/netmap && git checkout v11.3
... and I notice I forgot to change directory in my previous suggestion.
Why do you take v11.3 and not v11.4?
I agree v11.3 was closer to what I tested when I introduced this
dependency, but I'd rather use the latest release.
Regards,
Phil.
> RUN cd /usr/src/netmap/LINUX && ./configure --no-drivers --no-apps --kernel-dir=$(ls -d /usr/src/linux-headers-*-amd64) && make install
> ENV QEMU_CONFIGURE_OPTS --enable-netmap
>
>
> <snip>
>
> --
> Alex Bennée
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Qemu-devel] [PATCH] shippable: fix build
2019-02-20 17:24 ` Philippe Mathieu-Daudé
@ 2019-02-20 17:45 ` Alex Bennée
2019-02-20 18:00 ` Philippe Mathieu-Daudé
0 siblings, 1 reply; 8+ messages in thread
From: Alex Bennée @ 2019-02-20 17:45 UTC (permalink / raw)
To: Philippe Mathieu-Daudé; +Cc: Paolo Bonzini, qemu-devel
Philippe Mathieu-Daudé <philmd@redhat.com> writes:
> On 2/20/19 5:37 PM, Alex Bennée wrote:
>> Paolo Bonzini <pbonzini@redhat.com> writes:
>>
>>> It looks like something in netmap has changed and compilation fails:
>>>
>>> install -D libnetmap.a //usr/local/lib/libnetmap.a
>>> install: cannot stat libnetmap.a: No such file or directory
>>>
>>> Add an explicit "make" step to fix it.
>>
>> I took an alternate approach as tracking another projects master seems
>> like a bad idea:
>>
>> tests/docker: peg netmap code to a specific version
>>
>> Tracking head is always going to be at the whims of the upstream.
>> Let's use a defined release so things don't magically change under us.
>
> Oh now I see your reply...
>
>> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
>>
>> 1 file changed, 1 insertion(+)
>> tests/docker/dockerfiles/debian-amd64.docker | 1 +
>>
>> modified tests/docker/dockerfiles/debian-amd64.docker
>> @@ -33,6 +33,7 @@ RUN DEBIAN_FRONTEND=noninteractive eatmydata \
>> apt-get install -y --no-install-recommends \
>> linux-headers-amd64
>> RUN git clone https://github.com/luigirizzo/netmap.git /usr/src/netmap
>> +RUN cd /usr/src/netmap && git checkout v11.3
>
> ... and I notice I forgot to change directory in my previous suggestion.
>
> Why do you take v11.3 and not v11.4?
> I agree v11.3 was closer to what I tested when I introduced this
> dependency, but I'd rather use the latest release.
Hmm github hid the newer releases by default and has a Latest Release
button by v11.3.
--
Alex Bennée
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Qemu-devel] [PATCH] shippable: fix build
2019-02-20 17:45 ` Alex Bennée
@ 2019-02-20 18:00 ` Philippe Mathieu-Daudé
2019-02-21 9:14 ` Stefano Garzarella
0 siblings, 1 reply; 8+ messages in thread
From: Philippe Mathieu-Daudé @ 2019-02-20 18:00 UTC (permalink / raw)
To: Alex Bennée; +Cc: Paolo Bonzini, qemu-devel
On 2/20/19 6:45 PM, Alex Bennée wrote:
>
> Philippe Mathieu-Daudé <philmd@redhat.com> writes:
>
>> On 2/20/19 5:37 PM, Alex Bennée wrote:
>>> Paolo Bonzini <pbonzini@redhat.com> writes:
>>>
>>>> It looks like something in netmap has changed and compilation fails:
>>>>
>>>> install -D libnetmap.a //usr/local/lib/libnetmap.a
>>>> install: cannot stat libnetmap.a: No such file or directory
>>>>
>>>> Add an explicit "make" step to fix it.
>>>
>>> I took an alternate approach as tracking another projects master seems
>>> like a bad idea:
>>>
>>> tests/docker: peg netmap code to a specific version
>>>
>>> Tracking head is always going to be at the whims of the upstream.
>>> Let's use a defined release so things don't magically change under us.
>>
>> Oh now I see your reply...
>>
>>> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
>>>
>>> 1 file changed, 1 insertion(+)
>>> tests/docker/dockerfiles/debian-amd64.docker | 1 +
>>>
>>> modified tests/docker/dockerfiles/debian-amd64.docker
>>> @@ -33,6 +33,7 @@ RUN DEBIAN_FRONTEND=noninteractive eatmydata \
>>> apt-get install -y --no-install-recommends \
>>> linux-headers-amd64
>>> RUN git clone https://github.com/luigirizzo/netmap.git /usr/src/netmap
>>> +RUN cd /usr/src/netmap && git checkout v11.3
>>
>> ... and I notice I forgot to change directory in my previous suggestion.
>>
>> Why do you take v11.3 and not v11.4?
>> I agree v11.3 was closer to what I tested when I introduced this
>> dependency, but I'd rather use the latest release.
>
> Hmm github hid the newer releases by default and has a Latest Release
> button by v11.3.
I don't understand (this GitHub feature)...
I'm talking about this release:
https://github.com/luigirizzo/netmap/releases/tag/v11.4
The date is more recent that the v11.3. This looks like the latest
release to me.
Anyway I'm fine if you prefer v11.3.
Please send a formal patch because I don't want to confuse scripts
adding my R-b in Paolo's patch.
Regards,
Phil.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Qemu-devel] [PATCH] shippable: fix build
2019-02-20 18:00 ` Philippe Mathieu-Daudé
@ 2019-02-21 9:14 ` Stefano Garzarella
2019-02-21 9:24 ` Vincenzo Maffione
0 siblings, 1 reply; 8+ messages in thread
From: Stefano Garzarella @ 2019-02-21 9:14 UTC (permalink / raw)
To: Philippe Mathieu-Daudé
Cc: Vincenzo Maffione, Alex Bennée, Paolo Bonzini, qemu-devel
CCing Vincenzo, one of the maintainer of Netmap.
On Wed, Feb 20, 2019 at 07:00:19PM +0100, Philippe Mathieu-Daudé wrote:
> On 2/20/19 6:45 PM, Alex Bennée wrote:
> >
> > Philippe Mathieu-Daudé <philmd@redhat.com> writes:
> >
> >> On 2/20/19 5:37 PM, Alex Bennée wrote:
> >>> Paolo Bonzini <pbonzini@redhat.com> writes:
> >>>
> >>>> It looks like something in netmap has changed and compilation fails:
> >>>>
> >>>> install -D libnetmap.a //usr/local/lib/libnetmap.a
> >>>> install: cannot stat libnetmap.a: No such file or directory
> >>>>
> >>>> Add an explicit "make" step to fix it.
> >>>
> >>> I took an alternate approach as tracking another projects master seems
> >>> like a bad idea:
> >>>
> >>> tests/docker: peg netmap code to a specific version
> >>>
> >>> Tracking head is always going to be at the whims of the upstream.
> >>> Let's use a defined release so things don't magically change under us.
> >>
> >> Oh now I see your reply...
> >>
> >>> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> >>>
> >>> 1 file changed, 1 insertion(+)
> >>> tests/docker/dockerfiles/debian-amd64.docker | 1 +
> >>>
> >>> modified tests/docker/dockerfiles/debian-amd64.docker
> >>> @@ -33,6 +33,7 @@ RUN DEBIAN_FRONTEND=noninteractive eatmydata \
> >>> apt-get install -y --no-install-recommends \
> >>> linux-headers-amd64
> >>> RUN git clone https://github.com/luigirizzo/netmap.git /usr/src/netmap
> >>> +RUN cd /usr/src/netmap && git checkout v11.3
> >>
> >> ... and I notice I forgot to change directory in my previous suggestion.
> >>
> >> Why do you take v11.3 and not v11.4?
> >> I agree v11.3 was closer to what I tested when I introduced this
> >> dependency, but I'd rather use the latest release.
> >
> > Hmm github hid the newer releases by default and has a Latest Release
> > button by v11.3.
>
> I don't understand (this GitHub feature)...
>
> I'm talking about this release:
> https://github.com/luigirizzo/netmap/releases/tag/v11.4
>
> The date is more recent that the v11.3. This looks like the latest
> release to me.
>
> Anyway I'm fine if you prefer v11.3.
> Please send a formal patch because I don't want to confuse scripts
> adding my R-b in Paolo's patch.
>
> Regards,
>
> Phil.
>
--
Stefano Garzarella
Software Engineer @ Red Hat
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Qemu-devel] [PATCH] shippable: fix build
2019-02-21 9:14 ` Stefano Garzarella
@ 2019-02-21 9:24 ` Vincenzo Maffione
0 siblings, 0 replies; 8+ messages in thread
From: Vincenzo Maffione @ 2019-02-21 9:24 UTC (permalink / raw)
To: Stefano Garzarella
Cc: Philippe Mathieu-Daudé, Alex Bennée, Paolo Bonzini,
qemu-devel, Giuseppe Lettieri
Hi,
Yes, we added a static library that to ease application development
(libnetmap.a).
It looks like a configure/Makefile issue. Can you reproduce that?
(I'm CC-ing Giuseppe, who actually added libnetmap).
Cheers,
Vincenzo
Il giorno gio 21 feb 2019 alle ore 10:14 Stefano Garzarella <
sgarzare@redhat.com> ha scritto:
> CCing Vincenzo, one of the maintainer of Netmap.
>
> On Wed, Feb 20, 2019 at 07:00:19PM +0100, Philippe Mathieu-Daudé wrote:
> > On 2/20/19 6:45 PM, Alex Bennée wrote:
> > >
> > > Philippe Mathieu-Daudé <philmd@redhat.com> writes:
> > >
> > >> On 2/20/19 5:37 PM, Alex Bennée wrote:
> > >>> Paolo Bonzini <pbonzini@redhat.com> writes:
> > >>>
> > >>>> It looks like something in netmap has changed and compilation fails:
> > >>>>
> > >>>> install -D libnetmap.a //usr/local/lib/libnetmap.a
> > >>>> install: cannot stat libnetmap.a: No such file or directory
> > >>>>
> > >>>> Add an explicit "make" step to fix it.
> > >>>
> > >>> I took an alternate approach as tracking another projects master
> seems
> > >>> like a bad idea:
> > >>>
> > >>> tests/docker: peg netmap code to a specific version
> > >>>
> > >>> Tracking head is always going to be at the whims of the upstream.
> > >>> Let's use a defined release so things don't magically change under
> us.
> > >>
> > >> Oh now I see your reply...
> > >>
> > >>> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> > >>>
> > >>> 1 file changed, 1 insertion(+)
> > >>> tests/docker/dockerfiles/debian-amd64.docker | 1 +
> > >>>
> > >>> modified tests/docker/dockerfiles/debian-amd64.docker
> > >>> @@ -33,6 +33,7 @@ RUN DEBIAN_FRONTEND=noninteractive eatmydata \
> > >>> apt-get install -y --no-install-recommends \
> > >>> linux-headers-amd64
> > >>> RUN git clone https://github.com/luigirizzo/netmap.git
> /usr/src/netmap
> > >>> +RUN cd /usr/src/netmap && git checkout v11.3
> > >>
> > >> ... and I notice I forgot to change directory in my previous
> suggestion.
> > >>
> > >> Why do you take v11.3 and not v11.4?
> > >> I agree v11.3 was closer to what I tested when I introduced this
> > >> dependency, but I'd rather use the latest release.
> > >
> > > Hmm github hid the newer releases by default and has a Latest Release
> > > button by v11.3.
> >
> > I don't understand (this GitHub feature)...
> >
> > I'm talking about this release:
> > https://github.com/luigirizzo/netmap/releases/tag/v11.4
> >
> > The date is more recent that the v11.3. This looks like the latest
> > release to me.
> >
> > Anyway I'm fine if you prefer v11.3.
> > Please send a formal patch because I don't want to confuse scripts
> > adding my R-b in Paolo's patch.
> >
> > Regards,
> >
> > Phil.
> >
>
> --
>
> Stefano Garzarella
> Software Engineer @ Red Hat
>
--
Vincenzo
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2019-02-21 9:24 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-02-20 10:45 [Qemu-devel] [PATCH] shippable: fix build Paolo Bonzini
2019-02-20 16:37 ` Alex Bennée
2019-02-20 17:24 ` Philippe Mathieu-Daudé
2019-02-20 17:45 ` Alex Bennée
2019-02-20 18:00 ` Philippe Mathieu-Daudé
2019-02-21 9:14 ` Stefano Garzarella
2019-02-21 9:24 ` Vincenzo Maffione
2019-02-20 17:19 ` Philippe Mathieu-Daudé
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).