From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51894)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1beiTH-0001kY-S1
	for qemu-devel@nongnu.org; Tue, 30 Aug 2016 08:48:56 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1beiTC-0004Gz-Sk
	for qemu-devel@nongnu.org; Tue, 30 Aug 2016 08:48:55 -0400
Received: from mail-wm0-x241.google.com ([2a00:1450:400c:c09::241]:32891)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1beiTC-0004Gu-M2
	for qemu-devel@nongnu.org; Tue, 30 Aug 2016 08:48:50 -0400
Received: by mail-wm0-x241.google.com with SMTP id o80so3012787wme.0
	for <qemu-devel@nongnu.org>; Tue, 30 Aug 2016 05:48:50 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
References: <87mw8rumhb.fsf@blackfin.pond.sub.org>
	<87y4s8h5rh.fsf@blackfin.pond.sub.org>
	<876132olyi.fsf@blackfin.pond.sub.org>
	<87a8fucx33.fsf@dusky.pond.sub.org>
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <48b58aa4-4544-810f-282b-232fbc4d23c4@redhat.com>
Date: Tue, 30 Aug 2016 14:48:48 +0200
MIME-Version: 1.0
In-Reply-To: <87a8fucx33.fsf@dusky.pond.sub.org>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] MAINTAINERS leaves too many files uncovered
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>, qemu-devel <qemu-devel@nongnu.org>



On 30/08/2016 13:31, Markus Armbruster wrote:
> $ for i in `git-ls-files`; do [ "`scripts/get_maintainer.pl -f --no-git-fallback $i | grep -v '^qemu-devel@nongnu\.org'`" ] || echo $i; done >unmaintained-files
> $ grep -c '\.c$' unmaintained-files
> 402
> 
> 402 out of 2132 (19%).  More progress, but not yet there.

Not bad.

> $ git-diff --diff-filter=A --name-only 6138fbd | grep -c '\.c$'
> 215
> $ git-diff --diff-filter=A --name-only 6138fbd | grep '\.c$' | join unmaintained-files - | wc -l
> 86
> 
> This time, it's 86 out of 215 (40%).  Getting worse.  I'll cook up a
> patch to make checkpatch.pl catch such additions.

Good idea.

>>>> Apparently, nobody cares for tests:
>>>>
>>>>     $ grep '^tests/' unmaintained-files | grep -c '\.c$'
>>>>     654
>>>>     $ git-ls-files | grep '^tests/' | grep -c '\.c$'
>>>>     664
>>>
>>> Now 91 out of 665.
>>
>> 105 out of 687.
> 
> 114 out of 726.

I think this is expected to some extent.  Is it worth moving tests to
many tests subdirectories, e.g. hw/scsi/tests?  Many files would be
covered automatically.

> Active subsystems lacking a maintainer include tilegx, qdev, replay.

You, Eduardo, me?

> Headers that should probably be covered by existing MAINTAINERS stanzas
> include include/sysemu/block-backend.h include/qom/cpu.h
> include/hw/arm/xlnx-zynqmp.h.

Also:

hw/intc/gic* (ARM)
hw/*/mips* (MIPS)
hw/*/slavio* (SPARC)
libdecnumber/ (target-ppc/)

etc.

Any kind soul that converts the Coverity components into MAINTAINERS
patches?

Paolo