From: Michal Privoznik <mprivozn@redhat.com>
To: qemu-devel@nongnu.org
Cc: ehabkost@redhat.com
Subject: Re: [PATCH RESEND] hostmem: Don't report pmem attribute if unsupported
Date: Mon, 15 Feb 2021 13:34:05 +0100 [thread overview]
Message-ID: <48b5fe65-784a-17ab-c542-60e1b406e2a7@redhat.com> (raw)
In-Reply-To: <dfcc5dc7e2efc0283bc38e3036da2c0323621cdb.1611647111.git.mprivozn@redhat.com>
On 1/26/21 8:48 AM, Michal Privoznik wrote:
> When management applications (like Libvirt) want to check whether
> memory-backend-file.pmem is supported they can list object
> properties using 'qom-list-properties'. However, 'pmem' is
> declared always (and thus reported always) and only at runtime
> QEMU errors out if it was built without libpmem (and thus can not
> guarantee write persistence). This is suboptimal since we have
> ability to declare attributes at compile time.
>
> Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1915216
> Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
> Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com>
> Tested-by: Daniel Henrique Barboza <danielhb413@gmail.com>
> Reviewed-by: Igor Mammedov <imammedo@redhat.com>
> ---
>
> This is just a resend of a patch I've sent earlier with Reviewed-by and
> Tested-by added:
>
> https://lists.nongnu.org/archive/html/qemu-devel/2021-01/msg04558.html
>
> backends/hostmem-file.c | 13 ++++---------
> 1 file changed, 4 insertions(+), 9 deletions(-)
Polite ping, please.
Michal
next prev parent reply other threads:[~2021-02-15 12:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-26 7:48 [PATCH RESEND] hostmem: Don't report pmem attribute if unsupported Michal Privoznik
2021-02-15 12:34 ` Michal Privoznik [this message]
2021-02-16 22:23 ` Eduardo Habkost
2021-02-16 23:07 ` John Snow
2021-02-17 7:31 ` Michal Privoznik
2021-02-18 18:27 ` John Snow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48b5fe65-784a-17ab-c542-60e1b406e2a7@redhat.com \
--to=mprivozn@redhat.com \
--cc=ehabkost@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).