From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47658) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bjp1P-0004AR-Em for qemu-devel@nongnu.org; Tue, 13 Sep 2016 10:49:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bjp1L-0005z1-Ka for qemu-devel@nongnu.org; Tue, 13 Sep 2016 10:49:15 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55656) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bjp1L-0005xd-Bt for qemu-devel@nongnu.org; Tue, 13 Sep 2016 10:49:11 -0400 References: <1473750714-48290-1-git-send-email-aik@ozlabs.ru> From: Eric Blake Message-ID: <48ccbe12-9880-3ad7-92d9-d6a17b45b17b@redhat.com> Date: Tue, 13 Sep 2016 09:49:09 -0500 MIME-Version: 1.0 In-Reply-To: <1473750714-48290-1-git-send-email-aik@ozlabs.ru> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ut7eoTPdP2ENoWDLtw4OPdFjnNasX7vMr" Subject: Re: [Qemu-devel] [PATCH qemu v2] tap: Allow specifying a bridge List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexey Kardashevskiy , qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --ut7eoTPdP2ENoWDLtw4OPdFjnNasX7vMr From: Eric Blake To: Alexey Kardashevskiy , qemu-devel@nongnu.org Message-ID: <48ccbe12-9880-3ad7-92d9-d6a17b45b17b@redhat.com> Subject: Re: [PATCH qemu v2] tap: Allow specifying a bridge References: <1473750714-48290-1-git-send-email-aik@ozlabs.ru> In-Reply-To: <1473750714-48290-1-git-send-email-aik@ozlabs.ru> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 09/13/2016 02:11 AM, Alexey Kardashevskiy wrote: > The tap backend is already using qemu-bridge-helper to attach tap > interface to a bridge but (unlike the bridge backend) it always uses > the default bridge name - br0. >=20 > This adds a "br" property support to the tap backend. >=20 > Signed-off-by: Alexey Kardashevskiy > -- > Changes: > v2: > * documented a new member in json and hx > --- > net/tap.c | 4 +++- > qapi-schema.json | 3 +++ > qemu-options.hx | 12 +++++++----- > 3 files changed, 13 insertions(+), 6 deletions(-) >=20 > +++ b/qapi-schema.json > @@ -2575,6 +2575,8 @@ > # > # @downscript: #optional script to shut down the interface > # > +# @br: #optional bridge name Missing a '(since 2.8)' designator. Also, we don't have to abbreviate; 'bridge-name' may be easier to understand than 'br', as well as a mention of the default value if the parameter is not supplied. > +# > # @helper: #optional command to execute to configure bridge > # > # @sndbuf: #optional send buffer limit. Understands [TGMKkb] suffixes.= > @@ -2604,6 +2606,7 @@ > '*fds': 'str', > '*script': 'str', > '*downscript': 'str', > + '*br': 'str', > '*helper': 'str', > '*sndbuf': 'size', > '*vnet_hdr': 'bool', Oh, we already use underscore, so if you go with a longer name, 'bridge_name' would be more consistent than 'bridge-name', even though we prefer dash over underscore in new interfaces. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --ut7eoTPdP2ENoWDLtw4OPdFjnNasX7vMr Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJX2BHlAAoJEKeha0olJ0NqMlAH/2WB12JGE2295BxZtJzzozub 7dYq5uKYm2a2Cx3sRxPbNQi5drMBeSySMWxOz5rl0vaF5DjbiUjmN22Iv0jDGpkd 8Kkc0v1dAYkiCnWyYUzx8aRUKOfv5Qwui9iB/N9hP+ebUz93cnuQ/F4Cz6MlFcGP 9gCx55bBw7HsOu8ySQSuIY+Zc6U3HXxYQ69bFoKSSyHSj9TNYaslUqtC9rebhhyC e4Ubbu/oJ6dv4AUvXEUNN/zIz48lmUi654iocE0jAhqQVkEQIT1bfHlZYbdoHA2w Z6CMrV/G5yXbqzGQzfTpm4NcqlnMpYcs/7CTagF1JSWZ+TXtAEB53VzLo1G8bok= =i+Mc -----END PGP SIGNATURE----- --ut7eoTPdP2ENoWDLtw4OPdFjnNasX7vMr--