From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2E3B6C25B75 for ; Fri, 31 May 2024 05:11:37 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sCuXC-0002cf-Gc; Fri, 31 May 2024 01:10:34 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sCuXA-0002ai-PB for qemu-devel@nongnu.org; Fri, 31 May 2024 01:10:32 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sCuX8-0003HS-S6 for qemu-devel@nongnu.org; Fri, 31 May 2024 01:10:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1717132229; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=HIB+4J6+YwsybqqUFxdDVfaNxkcdiEIA2qvc35OANtQ=; b=eXnwu+3kPIChs+fjcz+ED2jwafW4YjGf5KO+IY7CNgWT4uLNYp7WzE8h6Kky1xW+JWSsUK UQQFbs9h3FrMN0k1OW6YD1Trde+y61MIfkg9pyM018+PIdWVKLRA1UtZjwVzFV0OapYip1 knRdFl+OMoQbEpbT0Bxzdu73etDS6eo= Received: from mail-ej1-f70.google.com (mail-ej1-f70.google.com [209.85.218.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-503-guxxUKGsPrqlxDmNfFiPBQ-1; Fri, 31 May 2024 01:10:27 -0400 X-MC-Unique: guxxUKGsPrqlxDmNfFiPBQ-1 Received: by mail-ej1-f70.google.com with SMTP id a640c23a62f3a-a64032a4667so58161766b.3 for ; Thu, 30 May 2024 22:10:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717132226; x=1717737026; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=HIB+4J6+YwsybqqUFxdDVfaNxkcdiEIA2qvc35OANtQ=; b=ALOSWWeHtKh0fX2LuDlJ64j3pp2C4uOjcKxaN1OztUrA469f4kYruj/oShY0QZP/P2 pYAV8Nr4eP9EOR6hdRspSGAoDXEJVbYj+pG61RVu/4Fh4PN0tXgUBHv/qx69XvF4zW5i ooszpqmWW7F7XDVg5+7WP8JJUQzFi5P1S2EiX8gxXQGPExsfBY1nLL0VUdgb2N5Zdbnr CLOCByB6hSqTphn96paYZ3MOcSjvgaS6NPeUJFP2GG99An+9+1OAUipUDxqWTUuupqXg 6xvErwl4CCplHLzthRRMBFkp4kIPfW2w07a3n4w4xpSxjnH4jbqUOLMFoZ8RrRaduuj/ QRrA== X-Gm-Message-State: AOJu0YwiOdZK2t9Wc464y/kqWd4dL6EQ2iowem4ft454gxnGdgZctEIU Ll3hQMXakBY+SB+/77hN3UQZoYh/p8WCCfuxGGK/UV2r8EJtpshlJs8C9okMFwHm7RyNepuJYSb z2tw3V/Ho5CQnBMu75OKRZrm2BAxiC31c2IK5C/9CzI8xugnL5woz X-Received: by 2002:a17:907:780a:b0:a67:7649:3c3f with SMTP id a640c23a62f3a-a681f87f528mr49659266b.6.1717132226234; Thu, 30 May 2024 22:10:26 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHadnvVcyGuyfsLJQDG53VIzBf9ghI5EoHUcBPhQHS2ezwGaewQKLyil+I2AMduF1mgIBnaEg== X-Received: by 2002:a17:907:780a:b0:a67:7649:3c3f with SMTP id a640c23a62f3a-a681f87f528mr49656666b.6.1717132225718; Thu, 30 May 2024 22:10:25 -0700 (PDT) Received: from [192.168.0.4] (ip-109-43-176-229.web.vodafone.de. [109.43.176.229]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a682ea1e5c4sm29306166b.115.2024.05.30.22.10.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 30 May 2024 22:10:25 -0700 (PDT) Message-ID: <48e4fe8f-7a3c-4b2f-a687-02613e3b5a26@redhat.com> Date: Fri, 31 May 2024 07:10:23 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] Use "void *" as parameter for functions that are used for aio_set_event_notifier() To: Stefan Hajnoczi Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org, Kevin Wolf , Hanna Reitz , Paolo Bonzini , Fam Zheng , =?UTF-8?Q?Philippe_Mathieu-Daud=C3=A9?= , Stefan Weil , "Maciej S. Szmigiero" , Keith Busch , Klaus Jensen , Jesper Devantier , =?UTF-8?Q?Eugenio_P=C3=A9rez?= , "Michael S. Tsirkin" , Akihiko Odaki , Peter Maydell References: <20240529174948.1241574-1-thuth@redhat.com> <20240529182222.GB1203999@fedora.redhat.com> From: Thomas Huth Content-Language: en-US Autocrypt: addr=thuth@redhat.com; keydata= xsFNBFH7eUwBEACzyOXKU+5Pcs6wNpKzrlJwzRl3VGZt95VCdb+FgoU9g11m7FWcOafrVRwU yYkTm9+7zBUc0sW5AuPGR/dp3pSLX/yFWsA/UB4nJsHqgDvDU7BImSeiTrnpMOTXb7Arw2a2 4CflIyFqjCpfDM4MuTmzTjXq4Uov1giGE9X6viNo1pxyEpd7PanlKNnf4PqEQp06X4IgUacW tSGj6Gcns1bCuHV8OPWLkf4hkRnu8hdL6i60Yxz4E6TqlrpxsfYwLXgEeswPHOA6Mn4Cso9O 0lewVYfFfsmokfAVMKWzOl1Sr0KGI5T9CpmRfAiSHpthhHWnECcJFwl72NTi6kUcUzG4se81 O6n9d/kTj7pzTmBdfwuOZ0YUSqcqs0W+l1NcASSYZQaDoD3/SLk+nqVeCBB4OnYOGhgmIHNW 0CwMRO/GK+20alxzk//V9GmIM2ACElbfF8+Uug3pqiHkVnKqM7W9/S1NH2qmxB6zMiJUHlTH gnVeZX0dgH27mzstcF786uPcdEqS0KJuxh2kk5IvUSL3Qn3ZgmgdxBMyCPciD/1cb7/Ahazr 3ThHQXSHXkH/aDXdfLsKVuwDzHLVSkdSnZdt5HHh75/NFHxwaTlydgfHmFFwodK8y/TjyiGZ zg2Kje38xnz8zKn9iesFBCcONXS7txENTzX0z80WKBhK+XSFJwARAQABzR5UaG9tYXMgSHV0 aCA8dGh1dGhAcmVkaGF0LmNvbT7CwXgEEwECACIFAlVgX6oCGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAAoJEC7Z13T+cC21EbIP/ii9cvT2HHGbFRl8HqGT6+7Wkb+XLMqJBMAIGiQK QIP3xk1HPTsLfVG0ao4hy/oYkGNOP8+ubLnZen6Yq3zAFiMhQ44lvgigDYJo3Ve59gfe99KX EbtB+X95ODARkq0McR6OAsPNJ7gpEUzfkQUUJTXRDQXfG/FX303Gvk+YU0spm2tsIKPl6AmV 1CegDljzjycyfJbk418MQmMu2T82kjrkEofUO2a24ed3VGC0/Uz//XCR2ZTo+vBoBUQl41BD eFFtoCSrzo3yPFS+w5fkH9NT8ChdpSlbNS32NhYQhJtr9zjWyFRf0Zk+T/1P7ECn6gTEkp5k ofFIA4MFBc/fXbaDRtBmPB0N9pqTFApIUI4vuFPPO0JDrII9dLwZ6lO9EKiwuVlvr1wwzsgq zJTPBU3qHaUO4d/8G+gD7AL/6T4zi8Jo/GmjBsnYaTzbm94lf0CjXjsOX3seMhaE6WAZOQQG tZHAO1kAPWpaxne+wtgMKthyPLNwelLf+xzGvrIKvLX6QuLoWMnWldu22z2ICVnLQChlR9d6 WW8QFEpo/FK7omuS8KvvopFcOOdlbFMM8Y/8vBgVMSsK6fsYUhruny/PahprPbYGiNIhKqz7 UvgyZVl4pBFjTaz/SbimTk210vIlkDyy1WuS8Zsn0htv4+jQPgo9rqFE4mipJjy/iboDzsFN BFH7eUwBEAC2nzfUeeI8dv0C4qrfCPze6NkryUflEut9WwHhfXCLjtvCjnoGqFelH/PE9NF4 4VPSCdvD1SSmFVzu6T9qWdcwMSaC+e7G/z0/AhBfqTeosAF5XvKQlAb9ZPkdDr7YN0a1XDfa +NgA+JZB4ROyBZFFAwNHT+HCnyzy0v9Sh3BgJJwfpXHH2l3LfncvV8rgFv0bvdr70U+On2XH 5bApOyW1WpIG5KPJlDdzcQTyptOJ1dnEHfwnABEfzI3dNf63rlxsGouX/NFRRRNqkdClQR3K gCwciaXfZ7ir7fF0u1N2UuLsWA8Ei1JrNypk+MRxhbvdQC4tyZCZ8mVDk+QOK6pyK2f4rMf/ WmqxNTtAVmNuZIwnJdjRMMSs4W4w6N/bRvpqtykSqx7VXcgqtv6eqoDZrNuhGbekQA0sAnCJ VPArerAZGArm63o39me/bRUQeQVSxEBmg66yshF9HkcUPGVeC4B0TPwz+HFcVhheo6hoJjLq knFOPLRj+0h+ZL+D0GenyqD3CyuyeTT5dGcNU9qT74bdSr20k/CklvI7S9yoQje8BeQAHtdV cvO8XCLrpGuw9SgOS7OP5oI26a0548M4KldAY+kqX6XVphEw3/6U1KTf7WxW5zYLTtadjISB X9xsRWSU+Yqs3C7oN5TIPSoj9tXMoxZkCIHWvnqGwZ7JhwARAQABwsFfBBgBAgAJBQJR+3lM AhsMAAoJEC7Z13T+cC21hPAQAIsBL9MdGpdEpvXs9CYrBkd6tS9mbaSWj6XBDfA1AEdQkBOn ZH1Qt7HJesk+qNSnLv6+jP4VwqK5AFMrKJ6IjE7jqgzGxtcZnvSjeDGPF1h2CKZQPpTw890k fy18AvgFHkVk2Oylyexw3aOBsXg6ukN44vIFqPoc+YSU0+0QIdYJp/XFsgWxnFIMYwDpxSHS 5fdDxUjsk3UBHZx+IhFjs2siVZi5wnHIqM7eK9abr2cK2weInTBwXwqVWjsXZ4tq5+jQrwDK cvxIcwXdUTLGxc4/Z/VRH1PZSvfQxdxMGmNTGaXVNfdFZjm4fz0mz+OUi6AHC4CZpwnsliGV ODqwX8Y1zic9viSTbKS01ZNp175POyWViUk9qisPZB7ypfSIVSEULrL347qY/hm9ahhqmn17 Ng255syASv3ehvX7iwWDfzXbA0/TVaqwa1YIkec+/8miicV0zMP9siRcYQkyTqSzaTFBBmqD oiT+z+/E59qj/EKfyce3sbC9XLjXv3mHMrq1tKX4G7IJGnS989E/fg6crv6NHae9Ckm7+lSs IQu4bBP2GxiRQ+NV3iV/KU3ebMRzqIC//DCOxzQNFNJAKldPe/bKZMCxEqtVoRkuJtNdp/5a yXFZ6TfE1hGKrDBYAm4vrnZ4CXFSBDllL59cFFOJCkn4Xboj/aVxxJxF30bn In-Reply-To: <20240529182222.GB1203999@fedora.redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=170.10.129.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.085, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 29/05/2024 20.22, Stefan Hajnoczi wrote: > On Wed, May 29, 2024 at 07:49:48PM +0200, Thomas Huth wrote: >> aio_set_event_notifier() and aio_set_event_notifier_poll() in >> util/aio-posix.c and util/aio-win32.c are casting function pointers of >> functions that take an "EventNotifier *" pointer as parameter to function >> pointers that take a "void *" pointer as parameter (i.e. the IOHandler >> type). When those function pointers are later used to call the referenced >> function, this triggers undefined behavior errors with the latest version >> of Clang in Fedora 40 when compiling with the option "-fsanitize=undefined". >> And this also prevents enabling the strict mode of CFI which is currently >> disabled with -fsanitize-cfi-icall-generalize-pointers. Thus let us avoid >> the problem by using "void *" as parameter in all spots where it is needed. >> >> Signed-off-by: Thomas Huth >> --- >> Yes, I know, the patch looks ugly ... but I don't see a better way to >> tackle this. If someone has a better idea, suggestions are welcome! > > An alternative is adding EventNotifierHandler *io_read, *io_poll_ready, > *io_poll_begin, and *io_poll_end fields to EventNotifier so that > aio_set_event_notifier() and aio_set_event_notifier_poll() can pass > helper functions to the underlying aio_set_fd_handler() and > aio_set_fd_poll() APIs. These helper functions then invoke the > EventNotifier callbacks: > > /* Helpers */ > static void event_notifier_io_read(void *opaque) > { > EventNotifier *notifier = opaque; > notifier->io_read(notifier); > } That's a nice idea, thanks, I'll give it a try! Thomas