From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Kt0Uo-0005iY-5M
	for qemu-devel@nongnu.org; Thu, 23 Oct 2008 09:45:02 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1Kt0Um-0005ea-15
	for qemu-devel@nongnu.org; Thu, 23 Oct 2008 09:45:00 -0400
Received: from [199.232.76.173] (port=39839 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Kt0Ul-0005eC-8I
	for qemu-devel@nongnu.org; Thu, 23 Oct 2008 09:44:59 -0400
Received: from mx2.redhat.com ([66.187.237.31]:46327)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <avi@redhat.com>) id 1Kt0Uk-0004bg-Ja
	for qemu-devel@nongnu.org; Thu, 23 Oct 2008 09:44:58 -0400
Message-ID: <49007FDE.8070806@redhat.com>
Date: Thu, 23 Oct 2008 15:45:02 +0200
From: Avi Kivity <avi@redhat.com>
MIME-Version: 1.0
References: <1224771556-11146-1-git-send-email-glommer@redhat.com>
	<1224771556-11146-18-git-send-email-glommer@redhat.com>
In-Reply-To: <1224771556-11146-18-git-send-email-glommer@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 17/32] build list of available accelerators
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Glauber Costa <glommer@redhat.com>
Cc: aliguori@us.ibm.com, jan.kiszka@siemens.com, jes@sgi.com, qemu-devel@nongnu.org, Glauber Costa <gcosta@redhat.com>, dmitry.baryshkov@siemens.com

Glauber Costa wrote:
> From: Glauber Costa <gcosta@redhat.com>
>
> instead of hardcoding kqemu_start() in exec.c, which would require
> such a hack for all available accelerators, semantics of register_qemu_accel()
> is changed a little bit. It only builds a list of available accelerators.
> The last one registered is the first tried.
>
> This is a temporary solution, since we don't control exactly the order in which
> things are loaded by the constructor attributes. The final goal is to have command
> line switches and priority lists to determine that.
>
> "info accelerator" is changed to accomodate it. It now prints a list of available
> accelerators, and only if one of them is active, a detailed description of it is printed.
>
>  #define MAX_INFO_BUF 1024
>  
>  typedef struct QEMUAccel {
> +    char *name;
>   

const, or warnings you get.

>  
> +typedef struct QEMUCont {
> +    QEMUAccel *acc;
> +    int active;
> +    struct QEMUCont *next;
> +} QEMUCont;
>   

The name is unclear.  But you could fold the structure into QEMUAccel, no?

-- 
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.