From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Kt0cU-00058K-B6
	for qemu-devel@nongnu.org; Thu, 23 Oct 2008 09:52:58 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1Kt0cS-00054i-75
	for qemu-devel@nongnu.org; Thu, 23 Oct 2008 09:52:57 -0400
Received: from [199.232.76.173] (port=46201 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Kt0cR-00054G-Sl
	for qemu-devel@nongnu.org; Thu, 23 Oct 2008 09:52:55 -0400
Received: from e4.ny.us.ibm.com ([32.97.182.144]:43400)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <aliguori@us.ibm.com>) id 1Kt0cR-0007mE-P7
	for qemu-devel@nongnu.org; Thu, 23 Oct 2008 09:52:55 -0400
Received: from d01relay04.pok.ibm.com (d01relay04.pok.ibm.com [9.56.227.236])
	by e4.ny.us.ibm.com (8.13.8/8.13.8) with ESMTP id m9NDqsj0009720
	for <qemu-devel@nongnu.org>; Thu, 23 Oct 2008 09:52:54 -0400
Received: from d01av03.pok.ibm.com (d01av03.pok.ibm.com [9.56.224.217])
	by d01relay04.pok.ibm.com (8.13.8/8.13.8/NCO v9.1) with ESMTP id
	m9NDqs47103942
	for <qemu-devel@nongnu.org>; Thu, 23 Oct 2008 09:52:54 -0400
Received: from d01av03.pok.ibm.com (loopback [127.0.0.1])
	by d01av03.pok.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id
	m9NDqsTI017695
	for <qemu-devel@nongnu.org>; Thu, 23 Oct 2008 09:52:54 -0400
Message-ID: <490081B4.9080008@us.ibm.com>
Date: Thu, 23 Oct 2008 08:52:52 -0500
From: Anthony Liguori <aliguori@us.ibm.com>
MIME-Version: 1.0
References: <1224771556-11146-1-git-send-email-glommer@redhat.com>
	<1224771556-11146-4-git-send-email-glommer@redhat.com>
In-Reply-To: <1224771556-11146-4-git-send-email-glommer@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 03/32] change definition of FILE for linux
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Glauber Costa <glommer@redhat.com>
Cc: jan.kiszka@siemens.com, jes@sgi.com, qemu-devel@nongnu.org, avi@qumranet.com, dmitry.baryshkov@siemens.com

Glauber Costa wrote:
> use _IO_FILE, as it seems to be the case.
>   

Why?  What is this fixing?

It seems to work fine today and I don't see how this is related to the 
series.

Regards,

Anthony Liguori

> Signed-off-by: Glauber Costa <glommer@redhat.com>
> ---
>  dyngen-exec.h |    6 ++++++
>  1 files changed, 6 insertions(+), 0 deletions(-)
>
> diff --git a/dyngen-exec.h b/dyngen-exec.h
> index 9260b6f..826ff46 100644
> --- a/dyngen-exec.h
> +++ b/dyngen-exec.h
> @@ -27,6 +27,10 @@
>  #define _FILEDEFED
>  #endif
>
> +#ifdef __linux__
> +#define __FILE_defined
> +#endif
> +
>  /* NOTE: standard headers should be used with special care at this
>     point because host CPU registers are used as global variables. Some
>     host headers do not allow that. */
> @@ -84,6 +88,8 @@ typedef void * host_reg_t;
>
>  #ifdef _BSD
>  typedef struct __sFILE FILE;
> +#elif defined(__linux__)
> +typedef struct _IO_FILE FILE;
>  #else
>  typedef struct FILE FILE;
>  #endif
>