From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Kt0iG-0003tt-76
	for qemu-devel@nongnu.org; Thu, 23 Oct 2008 09:58:56 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1Kt0iF-0003rr-0S
	for qemu-devel@nongnu.org; Thu, 23 Oct 2008 09:58:55 -0400
Received: from [199.232.76.173] (port=60963 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Kt0iE-0003rb-H0
	for qemu-devel@nongnu.org; Thu, 23 Oct 2008 09:58:54 -0400
Received: from e6.ny.us.ibm.com ([32.97.182.146]:51501)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <aliguori@us.ibm.com>) id 1Kt0iD-0001rU-Lj
	for qemu-devel@nongnu.org; Thu, 23 Oct 2008 09:58:53 -0400
Received: from d01relay02.pok.ibm.com (d01relay02.pok.ibm.com [9.56.227.234])
	by e6.ny.us.ibm.com (8.13.8/8.13.8) with ESMTP id m9NE1a62030713
	for <qemu-devel@nongnu.org>; Thu, 23 Oct 2008 10:01:36 -0400
Received: from d01av01.pok.ibm.com (d01av01.pok.ibm.com [9.56.224.215])
	by d01relay02.pok.ibm.com (8.13.8/8.13.8/NCO v9.1) with ESMTP id
	m9NDwofh092664
	for <qemu-devel@nongnu.org>; Thu, 23 Oct 2008 09:58:50 -0400
Received: from d01av01.pok.ibm.com (loopback [127.0.0.1])
	by d01av01.pok.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id
	m9NDwn3q004660
	for <qemu-devel@nongnu.org>; Thu, 23 Oct 2008 09:58:50 -0400
Message-ID: <49008318.6050408@us.ibm.com>
Date: Thu, 23 Oct 2008 08:58:48 -0500
From: Anthony Liguori <aliguori@us.ibm.com>
MIME-Version: 1.0
References: <1224771556-11146-1-git-send-email-glommer@redhat.com>
	<1224771556-11146-7-git-send-email-glommer@redhat.com>
In-Reply-To: <1224771556-11146-7-git-send-email-glommer@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 06/32] split kqemu_init into two
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Glauber Costa <glommer@redhat.com>
Cc: jan.kiszka@siemens.com, jes@sgi.com, qemu-devel@nongnu.org, avi@qumranet.com, Glauber Costa <gcosta@redhat.com>, dmitry.baryshkov@siemens.com

Glauber Costa wrote:
> From: Glauber Costa <gcosta@redhat.com>
>
> we separate kqemu_init() into a part that depends on env,
> and other that does not. The later can be initialized earlier
>   

This patch seems harmless but I can't reasonably infer why this change 
is necessary.  What's the advantage of splitting the initialization into 
two parts?

Regards,

Anthony Liguori