From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Kt0k0-0005bk-R6
	for qemu-devel@nongnu.org; Thu, 23 Oct 2008 10:00:44 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1Kt0jz-0005a5-45
	for qemu-devel@nongnu.org; Thu, 23 Oct 2008 10:00:44 -0400
Received: from [199.232.76.173] (port=32773 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Kt0jy-0005Zk-QL
	for qemu-devel@nongnu.org; Thu, 23 Oct 2008 10:00:42 -0400
Received: from e2.ny.us.ibm.com ([32.97.182.142]:34516)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <aliguori@us.ibm.com>) id 1Kt0jy-0002Z1-IZ
	for qemu-devel@nongnu.org; Thu, 23 Oct 2008 10:00:42 -0400
Received: from d01relay07.pok.ibm.com (d01relay07.pok.ibm.com [9.56.227.147])
	by e2.ny.us.ibm.com (8.13.8/8.13.8) with ESMTP id m9NE0e1E002053
	for <qemu-devel@nongnu.org>; Thu, 23 Oct 2008 10:00:40 -0400
Received: from d03av01.boulder.ibm.com (d03av01.boulder.ibm.com [9.17.195.167])
	by d01relay07.pok.ibm.com (8.13.8/8.13.8/NCO v9.1) with ESMTP id
	m9NE0YCq1024254
	for <qemu-devel@nongnu.org>; Thu, 23 Oct 2008 10:00:35 -0400
Received: from d03av01.boulder.ibm.com (loopback [127.0.0.1])
	by d03av01.boulder.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id
	m9NE0WgR011327
	for <qemu-devel@nongnu.org>; Thu, 23 Oct 2008 08:00:32 -0600
Message-ID: <49008379.9020904@us.ibm.com>
Date: Thu, 23 Oct 2008 09:00:25 -0500
From: Anthony Liguori <aliguori@us.ibm.com>
MIME-Version: 1.0
References: <1224771556-11146-1-git-send-email-glommer@redhat.com>
	<1224771556-11146-8-git-send-email-glommer@redhat.com>
In-Reply-To: <1224771556-11146-8-git-send-email-glommer@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 07/32] introduce QEMUAccel and fill it with
 interrupt specific driver
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Glauber Costa <glommer@redhat.com>
Cc: jan.kiszka@siemens.com, jes@sgi.com, qemu-devel@nongnu.org, avi@qumranet.com, Glauber Costa <gcosta@redhat.com>, dmitry.baryshkov@siemens.com

Glauber Costa wrote:
> From: Glauber Costa <gcosta@redhat.com>
>
> This patch introduces QEMUAccel, a placeholder for function pointers
> that aims at helping qemu to abstract accelerators such as kqemu and
> kvm (actually, the 'accelerator' name was proposed by avi kivity, since
> he loves referring to kvm that way).
>
> To begin with, the accelerator is given the opportunity to register a
> cpu_interrupt function, to be called after the raw cpu_interrupt.
> This has the side effect of, for the kqemu accelerator, calling kqemu_cpu_interrupt
> everytime, which didn't use to happen. But looking at the code, this seems safe to me.
>
> This patch applies on raw qemu.
>
>   

See my previous bit of feedback.  cpu_interrupt place to be hooking.  It 
really ought to be an io_window or cpu_loop_exit hook or something like 
that.

Regards,

Anthony Liguori