From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Kt1tv-0003PO-9i
	for qemu-devel@nongnu.org; Thu, 23 Oct 2008 11:15:03 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1Kt1tu-0003P0-N4
	for qemu-devel@nongnu.org; Thu, 23 Oct 2008 11:15:02 -0400
Received: from [199.232.76.173] (port=48791 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Kt1tu-0003Ot-EL
	for qemu-devel@nongnu.org; Thu, 23 Oct 2008 11:15:02 -0400
Received: from mx2.redhat.com ([66.187.237.31]:45932)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <avi@redhat.com>) id 1Kt1tu-0003ve-DA
	for qemu-devel@nongnu.org; Thu, 23 Oct 2008 11:15:02 -0400
Message-ID: <490094FB.5080600@redhat.com>
Date: Thu, 23 Oct 2008 17:15:07 +0200
From: Avi Kivity <avi@redhat.com>
MIME-Version: 1.0
References: <1224771556-11146-1-git-send-email-glommer@redhat.com>
	<1224771556-11146-18-git-send-email-glommer@redhat.com>
	<49007FDE.8070806@redhat.com>
	<20081023150906.GM18872@poweredge.glommer>
In-Reply-To: <20081023150906.GM18872@poweredge.glommer>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 17/32] build list of available accelerators
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Glauber Costa <glommer@redhat.com>
Cc: aliguori@us.ibm.com, jan.kiszka@siemens.com, jes@sgi.com, qemu-devel@nongnu.org, Glauber Costa <gcosta@redhat.com>, dmitry.baryshkov@siemens.com


>>>  +typedef struct QEMUCont {
>>> +    QEMUAccel *acc;
>>> +    int active;
>>> +    struct QEMUCont *next;
>>> +} QEMUCont;
>>>   
>>>       
>> The name is unclear.  But you could fold the structure into QEMUAccel, no?
>>     
> Yes, it was folded in my first version. It is separated just to allow external
> accelerators to register themselves without messing with the accelerator list, which
> would be internal. But I'm probably just being overzealous.
>
>   

You could still have a registration function.  The accelerator itself 
would not need to touch the members.

-- 
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.