qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Anthony Liguori <anthony@codemonkey.ws>
To: Paul Brook <paul@codesourcery.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [5524] Fix windows build after migration changes
Date: Fri, 24 Oct 2008 11:49:25 -0500	[thread overview]
Message-ID: <4901FC95.8050000@codemonkey.ws> (raw)
In-Reply-To: <200810241638.00364.paul@codesourcery.com>

Paul Brook wrote:
> On Friday 24 October 2008, Anthony Liguori wrote:
>   
>> Robert Riebisch wrote:
>>     
>>> Anthony Liguori wrote:
>>>       
>>>> That would be great.  I don't know that we want to go on the current
>>>> directory though.  There's a Windows API for finding Program Files.
>>>> That's probably what we want to do.
>>>>         
>>> Why do you want to look for "Program Files" instead? Just let QEMU
>>> determine its own folder via GetModuleFileName() and look there for the
>>> BIOS files.
>>>       
>> That's not the same as CWD and is probably the right thing to do.
>>     
>
> We could also do the same thing for Linux et al.
>   

On Linux, I guess we could readlink(/proc/self/exe), but I don't know 
what we could do on other OSes.  In general, argv[0] isn't very useful.

What I had suggested to someone a while back, was that first, we should 
refactor things so that we can try to read all of the bios/keymap files 
from a number of paths.  That way, we could try the current path, the -L 
path, the path of the exe, etc.   The only problem with that it can 
become confusing trying to figure out what bios you are using.

Regards,

Anthony Liguori

> Paul
>   

  reply	other threads:[~2008-10-24 16:49 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-24 14:11 [Qemu-devel] [5524] Fix windows build after migration changes Anthony Liguori
2008-10-24 14:18 ` Robert Riebisch
2008-10-24 14:22   ` Glauber Costa
2008-10-24 14:55     ` Robert Riebisch
2008-10-24 15:05       ` Glauber Costa
2008-10-24 15:08         ` Robert Riebisch
2008-10-24 15:13           ` Glauber Costa
2008-10-24 14:25   ` Anthony Liguori
2008-10-24 15:01     ` Robert Riebisch
2008-10-24 15:11       ` Anthony Liguori
2008-10-24 15:13         ` Glauber Costa
2008-10-24 15:37         ` Paul Brook
2008-10-24 16:49           ` Anthony Liguori [this message]
2008-10-24 18:44           ` Andreas Färber

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4901FC95.8050000@codemonkey.ws \
    --to=anthony@codemonkey.ws \
    --cc=paul@codesourcery.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).