qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Avi Kivity <avi@redhat.com>
To: Glauber Costa <glommer@redhat.com>
Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [PATCH 1/2] trace io operations
Date: Sun, 26 Oct 2008 15:25:58 +0200	[thread overview]
Message-ID: <49046FE6.9070302@redhat.com> (raw)
In-Reply-To: <1224863716-23793-2-git-send-email-glommer@redhat.com>

Glauber Costa wrote:
>                                       memory was accessed */             \
> +    uint32_t mmio_read_count;                                                \
> +    uint32_t pio_read_count;                                                 \
> +    uint32_t mmio_write_count;                                                \
> +    uint32_t pio_write_count;                                                 \
>   

Will easily overflow.

-- 
error compiling committee.c: too many arguments to function

  reply	other threads:[~2008-10-26 13:26 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-24 15:55 [Qemu-devel] [PATCH 0/2] Add generic infrastructure to trace I/O Glauber Costa
2008-10-24 15:55 ` [Qemu-devel] [PATCH 1/2] trace io operations Glauber Costa
2008-10-26 13:25   ` Avi Kivity [this message]
2008-10-24 15:55 ` [Qemu-devel] [PATCH 2/2] new monitor command: info iostats Glauber Costa
2008-10-26 13:24   ` [Qemu-devel] " Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49046FE6.9070302@redhat.com \
    --to=avi@redhat.com \
    --cc=aliguori@us.ibm.com \
    --cc=glommer@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).